Commit 2e1b9e1e authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jiri Kosina

HID: rmi: Simplify an error handling path in 'rmi_hid_read_block()'

The 'RMI_READ_REQUEST_PENDING' bit is already cleared in the error handling
path. There is no need to reset it twice.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent b8a75ead
...@@ -217,7 +217,6 @@ static int rmi_hid_read_block(struct rmi_transport_dev *xport, u16 addr, ...@@ -217,7 +217,6 @@ static int rmi_hid_read_block(struct rmi_transport_dev *xport, u16 addr,
ret = rmi_write_report(hdev, data->writeReport, ret = rmi_write_report(hdev, data->writeReport,
data->output_report_size); data->output_report_size);
if (ret != data->output_report_size) { if (ret != data->output_report_size) {
clear_bit(RMI_READ_REQUEST_PENDING, &data->flags);
dev_err(&hdev->dev, dev_err(&hdev->dev,
"failed to write request output report (%d)\n", "failed to write request output report (%d)\n",
ret); ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment