Commit 2eaad1fd authored by Mike Travis's avatar Mike Travis Committed by H. Peter Anvin

x86: Limit the number of processor bootup messages

When there are a large number of processors in a system, there
is an excessive amount of messages sent to the system console.
It's estimated that with 4096 processors in a system, and the
console baudrate set to 56K, the startup messages will take
about 84 minutes to clear the serial port.

This set of patches limits the number of repetitious messages
which contain no additional information.  Much of this information
is obtainable from the /proc and /sysfs.   Some of the messages
are also sent to the kernel log buffer as KERN_DEBUG messages so
dmesg can be used to examine more closely any details specific to
a problem.

The new cpu bootup sequence for system_state == SYSTEM_BOOTING:

Booting Node   0, Processors  #1 #2 #3 #4 #5 #6 #7 Ok.
Booting Node   1, Processors  #8 #9 #10 #11 #12 #13 #14 #15 Ok.
...
Booting Node   3, Processors  #56 #57 #58 #59 #60 #61 #62 #63 Ok.
Brought up 64 CPUs

After the system is running, a single line boot message is displayed
when CPU's are hotplugged on:

    Booting Node %d Processor %d APIC 0x%x

Status of the following lines:

    CPU: Physical Processor ID:		printed once (for boot cpu)
    CPU: Processor Core ID:		printed once (for boot cpu)
    CPU: Hyper-Threading is disabled	printed once (for boot cpu)
    CPU: Thermal monitoring enabled	printed once (for boot cpu)
    CPU %d/0x%x -> Node %d:		removed
    CPU %d is now offline:		only if system_state == RUNNING
    Initializing CPU#%d:		KERN_DEBUG
Signed-off-by: default avatarMike Travis <travis@sgi.com>
LKML-Reference: <4B219E28.8080601@sgi.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 450b1e8d
...@@ -74,6 +74,7 @@ void __cpuinit detect_extended_topology(struct cpuinfo_x86 *c) ...@@ -74,6 +74,7 @@ void __cpuinit detect_extended_topology(struct cpuinfo_x86 *c)
unsigned int eax, ebx, ecx, edx, sub_index; unsigned int eax, ebx, ecx, edx, sub_index;
unsigned int ht_mask_width, core_plus_mask_width; unsigned int ht_mask_width, core_plus_mask_width;
unsigned int core_select_mask, core_level_siblings; unsigned int core_select_mask, core_level_siblings;
static bool printed;
if (c->cpuid_level < 0xb) if (c->cpuid_level < 0xb)
return; return;
...@@ -127,12 +128,14 @@ void __cpuinit detect_extended_topology(struct cpuinfo_x86 *c) ...@@ -127,12 +128,14 @@ void __cpuinit detect_extended_topology(struct cpuinfo_x86 *c)
c->x86_max_cores = (core_level_siblings / smp_num_siblings); c->x86_max_cores = (core_level_siblings / smp_num_siblings);
if (!printed) {
printk(KERN_INFO "CPU: Physical Processor ID: %d\n", printk(KERN_INFO "CPU: Physical Processor ID: %d\n",
c->phys_proc_id); c->phys_proc_id);
if (c->x86_max_cores > 1) if (c->x86_max_cores > 1)
printk(KERN_INFO "CPU: Processor Core ID: %d\n", printk(KERN_INFO "CPU: Processor Core ID: %d\n",
c->cpu_core_id); c->cpu_core_id);
printed = 1;
}
return; return;
#endif #endif
} }
...@@ -375,8 +375,6 @@ static void __cpuinit srat_detect_node(struct cpuinfo_x86 *c) ...@@ -375,8 +375,6 @@ static void __cpuinit srat_detect_node(struct cpuinfo_x86 *c)
node = nearby_node(apicid); node = nearby_node(apicid);
} }
numa_set_node(cpu, node); numa_set_node(cpu, node);
printk(KERN_INFO "CPU %d/0x%x -> Node %d\n", cpu, apicid, node);
#endif #endif
} }
......
...@@ -427,6 +427,7 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c) ...@@ -427,6 +427,7 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
#ifdef CONFIG_X86_HT #ifdef CONFIG_X86_HT
u32 eax, ebx, ecx, edx; u32 eax, ebx, ecx, edx;
int index_msb, core_bits; int index_msb, core_bits;
static bool printed;
if (!cpu_has(c, X86_FEATURE_HT)) if (!cpu_has(c, X86_FEATURE_HT))
return; return;
...@@ -442,7 +443,7 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c) ...@@ -442,7 +443,7 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
smp_num_siblings = (ebx & 0xff0000) >> 16; smp_num_siblings = (ebx & 0xff0000) >> 16;
if (smp_num_siblings == 1) { if (smp_num_siblings == 1) {
printk(KERN_INFO "CPU: Hyper-Threading is disabled\n"); printk_once(KERN_INFO "CPU0: Hyper-Threading is disabled\n");
goto out; goto out;
} }
...@@ -469,11 +470,12 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c) ...@@ -469,11 +470,12 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
((1 << core_bits) - 1); ((1 << core_bits) - 1);
out: out:
if ((c->x86_max_cores * smp_num_siblings) > 1) { if (!printed && (c->x86_max_cores * smp_num_siblings) > 1) {
printk(KERN_INFO "CPU: Physical Processor ID: %d\n", printk(KERN_INFO "CPU: Physical Processor ID: %d\n",
c->phys_proc_id); c->phys_proc_id);
printk(KERN_INFO "CPU: Processor Core ID: %d\n", printk(KERN_INFO "CPU: Processor Core ID: %d\n",
c->cpu_core_id); c->cpu_core_id);
printed = 1;
} }
#endif #endif
} }
...@@ -1115,7 +1117,7 @@ void __cpuinit cpu_init(void) ...@@ -1115,7 +1117,7 @@ void __cpuinit cpu_init(void)
if (cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)) if (cpumask_test_and_set_cpu(cpu, cpu_initialized_mask))
panic("CPU#%d already initialized!\n", cpu); panic("CPU#%d already initialized!\n", cpu);
printk(KERN_INFO "Initializing CPU#%d\n", cpu); pr_debug("Initializing CPU#%d\n", cpu);
clear_in_cr4(X86_CR4_VME|X86_CR4_PVI|X86_CR4_TSD|X86_CR4_DE); clear_in_cr4(X86_CR4_VME|X86_CR4_PVI|X86_CR4_TSD|X86_CR4_DE);
......
...@@ -270,8 +270,6 @@ static void __cpuinit srat_detect_node(struct cpuinfo_x86 *c) ...@@ -270,8 +270,6 @@ static void __cpuinit srat_detect_node(struct cpuinfo_x86 *c)
node = cpu_to_node(cpu); node = cpu_to_node(cpu);
} }
numa_set_node(cpu, node); numa_set_node(cpu, node);
printk(KERN_INFO "CPU %d/0x%x -> Node %d\n", cpu, apicid, node);
#endif #endif
} }
......
...@@ -339,8 +339,8 @@ void intel_init_thermal(struct cpuinfo_x86 *c) ...@@ -339,8 +339,8 @@ void intel_init_thermal(struct cpuinfo_x86 *c)
l = apic_read(APIC_LVTTHMR); l = apic_read(APIC_LVTTHMR);
apic_write(APIC_LVTTHMR, l & ~APIC_LVT_MASKED); apic_write(APIC_LVTTHMR, l & ~APIC_LVT_MASKED);
printk(KERN_INFO "CPU%d: Thermal monitoring enabled (%s)\n", printk_once(KERN_INFO "CPU0: Thermal monitoring enabled (%s)\n",
cpu, tm2 ? "TM2" : "TM1"); tm2 ? "TM2" : "TM1");
/* enable thermal throttle processing */ /* enable thermal throttle processing */
atomic_set(&therm_throt_en, 1); atomic_set(&therm_throt_en, 1);
......
...@@ -671,6 +671,26 @@ static void __cpuinit do_fork_idle(struct work_struct *work) ...@@ -671,6 +671,26 @@ static void __cpuinit do_fork_idle(struct work_struct *work)
complete(&c_idle->done); complete(&c_idle->done);
} }
/* reduce the number of lines printed when booting a large cpu count system */
static void __cpuinit announce_cpu(int cpu, int apicid)
{
static int current_node = -1;
int node = cpu_to_node(cpu);
if (system_state == SYSTEM_BOOTING) {
if (node != current_node) {
if (current_node > (-1))
pr_cont(" Ok.\n");
current_node = node;
pr_info("Booting Node %3d, Processors ", node);
}
pr_cont(" #%d%s", cpu, cpu == (nr_cpu_ids - 1) ? " Ok.\n" : "");
return;
} else
pr_info("Booting Node %d Processor %d APIC 0x%x\n",
node, cpu, apicid);
}
/* /*
* NOTE - on most systems this is a PHYSICAL apic ID, but on multiquad * NOTE - on most systems this is a PHYSICAL apic ID, but on multiquad
* (ie clustered apic addressing mode), this is a LOGICAL apic ID. * (ie clustered apic addressing mode), this is a LOGICAL apic ID.
...@@ -738,8 +758,7 @@ static int __cpuinit do_boot_cpu(int apicid, int cpu) ...@@ -738,8 +758,7 @@ static int __cpuinit do_boot_cpu(int apicid, int cpu)
start_ip = setup_trampoline(); start_ip = setup_trampoline();
/* So we see what's up */ /* So we see what's up */
printk(KERN_INFO "Booting processor %d APIC 0x%x ip 0x%lx\n", announce_cpu(cpu, apicid);
cpu, apicid, start_ip);
/* /*
* This grunge runs the startup process for * This grunge runs the startup process for
...@@ -788,21 +807,17 @@ static int __cpuinit do_boot_cpu(int apicid, int cpu) ...@@ -788,21 +807,17 @@ static int __cpuinit do_boot_cpu(int apicid, int cpu)
udelay(100); udelay(100);
} }
if (cpumask_test_cpu(cpu, cpu_callin_mask)) { if (cpumask_test_cpu(cpu, cpu_callin_mask))
/* number CPUs logically, starting from 1 (BSP is 0) */ pr_debug("CPU%d: has booted.\n", cpu);
pr_debug("OK.\n"); else {
printk(KERN_INFO "CPU%d: ", cpu);
print_cpu_info(&cpu_data(cpu));
pr_debug("CPU has booted.\n");
} else {
boot_error = 1; boot_error = 1;
if (*((volatile unsigned char *)trampoline_base) if (*((volatile unsigned char *)trampoline_base)
== 0xA5) == 0xA5)
/* trampoline started but...? */ /* trampoline started but...? */
printk(KERN_ERR "Stuck ??\n"); pr_err("CPU%d: Stuck ??\n", cpu);
else else
/* trampoline code not run */ /* trampoline code not run */
printk(KERN_ERR "Not responding.\n"); pr_err("CPU%d: Not responding.\n", cpu);
if (apic->inquire_remote_apic) if (apic->inquire_remote_apic)
apic->inquire_remote_apic(apicid); apic->inquire_remote_apic(apicid);
} }
...@@ -1293,14 +1308,16 @@ void native_cpu_die(unsigned int cpu) ...@@ -1293,14 +1308,16 @@ void native_cpu_die(unsigned int cpu)
for (i = 0; i < 10; i++) { for (i = 0; i < 10; i++) {
/* They ack this in play_dead by setting CPU_DEAD */ /* They ack this in play_dead by setting CPU_DEAD */
if (per_cpu(cpu_state, cpu) == CPU_DEAD) { if (per_cpu(cpu_state, cpu) == CPU_DEAD) {
printk(KERN_INFO "CPU %d is now offline\n", cpu); if (system_state == SYSTEM_RUNNING)
pr_info("CPU %u is now offline\n", cpu);
if (1 == num_online_cpus()) if (1 == num_online_cpus())
alternatives_smp_switch(0); alternatives_smp_switch(0);
return; return;
} }
msleep(100); msleep(100);
} }
printk(KERN_ERR "CPU %u didn't die...\n", cpu); pr_err("CPU %u didn't die...\n", cpu);
} }
void play_dead_common(void) void play_dead_common(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment