Commit 301b0404 authored by Benjamin Beichler's avatar Benjamin Beichler Committed by Johannes Berg

mac80211_hwsim: add nl_err_msg in hwsim_new_radio in netlink case

Add a NL_ERR_MSG in case of creating a radio by a netlink message to give
clear output to the creating process instead of creating only a debug
message in kernel log. The same function is used for the creation while
module load, so keep the old message, although it should never be thrown
while load, because the module controls all mac addresses.
Signed-off-by: default avatarBenjamin Beichler <benjamin.beichler@uni-rostock.de>
[remove message, add missing braces]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent cb1a5bae
...@@ -2797,8 +2797,11 @@ static int mac80211_hwsim_new_radio(struct genl_info *info, ...@@ -2797,8 +2797,11 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
err = rhashtable_insert_fast(&hwsim_radios_rht, &data->rht, err = rhashtable_insert_fast(&hwsim_radios_rht, &data->rht,
hwsim_rht_params); hwsim_rht_params);
if (err < 0) { if (err < 0) {
pr_debug("mac80211_hwsim: radio index %d already present\n", if (info) {
idx); GENL_SET_ERR_MSG(info, "perm addr already present");
NL_SET_BAD_ATTR(info->extack,
info->attrs[HWSIM_ATTR_PERM_ADDR]);
}
spin_unlock_bh(&hwsim_radio_lock); spin_unlock_bh(&hwsim_radio_lock);
goto failed_final_insert; goto failed_final_insert;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment