Commit 3082b9be authored by Arend van Spriel's avatar Arend van Spriel Committed by John W. Linville

brcmfmac: make pointer type constant in brcmf_set_management_ie()

The vendor ie buffer passed to brcmf_set_management_ie() is not modified
and the caller always provided a constant buffer, which needed a cast.
Better making the buffer parameter of the function constant so the
casts can be removed.
Reviewed-by: default avatarHante Meuleman <meuleman@broadcom.com>
Reviewed-by: default avatarPieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarFranky Lin <frankyl@broadcom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 0ecd8164
...@@ -3681,7 +3681,7 @@ brcmf_configure_wpaie(struct net_device *ndev, struct brcmf_vs_tlv *wpa_ie, ...@@ -3681,7 +3681,7 @@ brcmf_configure_wpaie(struct net_device *ndev, struct brcmf_vs_tlv *wpa_ie,
} }
static s32 static s32
brcmf_parse_vndr_ies(u8 *vndr_ie_buf, u32 vndr_ie_len, brcmf_parse_vndr_ies(const u8 *vndr_ie_buf, u32 vndr_ie_len,
struct parsed_vndr_ies *vndr_ies) struct parsed_vndr_ies *vndr_ies)
{ {
s32 err = 0; s32 err = 0;
...@@ -3760,10 +3760,10 @@ brcmf_vndr_ie(u8 *iebuf, s32 pktflag, u8 *ie_ptr, u32 ie_len, s8 *add_del_cmd) ...@@ -3760,10 +3760,10 @@ brcmf_vndr_ie(u8 *iebuf, s32 pktflag, u8 *ie_ptr, u32 ie_len, s8 *add_del_cmd)
return ie_len + VNDR_IE_HDR_SIZE; return ie_len + VNDR_IE_HDR_SIZE;
} }
static s32 static
brcmf_set_management_ie(struct brcmf_cfg80211_info *cfg, s32 brcmf_set_management_ie(struct brcmf_cfg80211_info *cfg,
struct net_device *ndev, s32 pktflag, struct net_device *ndev, s32 pktflag,
u8 *vndr_ie_buf, u32 vndr_ie_len) const u8 *vndr_ie_buf, u32 vndr_ie_len)
{ {
struct brcmf_if *ifp = netdev_priv(ndev); struct brcmf_if *ifp = netdev_priv(ndev);
struct vif_saved_ie *saved_ie = &ifp->vif->saved_ie; struct vif_saved_ie *saved_ie = &ifp->vif->saved_ie;
...@@ -4004,7 +4004,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev, ...@@ -4004,7 +4004,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev,
/* Set Beacon IEs to FW */ /* Set Beacon IEs to FW */
err = brcmf_set_management_ie(cfg, ndev, err = brcmf_set_management_ie(cfg, ndev,
VNDR_IE_BEACON_FLAG, VNDR_IE_BEACON_FLAG,
(u8 *)settings->beacon.tail, settings->beacon.tail,
settings->beacon.tail_len); settings->beacon.tail_len);
if (err) if (err)
WL_ERR("Set Beacon IE Failed\n"); WL_ERR("Set Beacon IE Failed\n");
...@@ -4014,7 +4014,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev, ...@@ -4014,7 +4014,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev,
/* Set Probe Response IEs to FW */ /* Set Probe Response IEs to FW */
err = brcmf_set_management_ie(cfg, ndev, err = brcmf_set_management_ie(cfg, ndev,
VNDR_IE_PRBRSP_FLAG, VNDR_IE_PRBRSP_FLAG,
(u8 *)settings->beacon.proberesp_ies, settings->beacon.proberesp_ies,
settings->beacon.proberesp_ies_len); settings->beacon.proberesp_ies_len);
if (err) if (err)
WL_ERR("Set Probe Resp IE Failed\n"); WL_ERR("Set Probe Resp IE Failed\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment