Commit 33d3dfff authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Eric Paris

fanotify: remove outgoing function checks in fanotify.h

A number of validity checks on outgoing data are done in static inlines but
are only used in one place.  Instead just do them where they are used for
readability.
Signed-off-by: default avatarAndreas Gruenbacher <agruen@suse.de>
Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent 88380fe6
#include <linux/fanotify.h>
#include <linux/fdtable.h> #include <linux/fdtable.h>
#include <linux/fsnotify_backend.h> #include <linux/fsnotify_backend.h>
#include <linux/init.h> #include <linux/init.h>
...@@ -5,8 +6,6 @@ ...@@ -5,8 +6,6 @@
#include <linux/mount.h> #include <linux/mount.h>
#include <linux/types.h> #include <linux/types.h>
#include "fanotify.h"
static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new) static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new)
{ {
pr_debug("%s: old=%p new=%p\n", __func__, old, new); pr_debug("%s: old=%p new=%p\n", __func__, old, new);
......
#include <linux/fanotify.h>
#include <linux/fsnotify_backend.h>
#include <linux/net.h>
#include <linux/kernel.h>
#include <linux/types.h>
extern const struct fsnotify_ops fanotify_fsnotify_ops;
static inline __u32 fanotify_outgoing_mask(__u32 mask)
{
return mask & FAN_ALL_OUTGOING_EVENTS;
}
#include <linux/fanotify.h>
#include <linux/fcntl.h> #include <linux/fcntl.h>
#include <linux/file.h> #include <linux/file.h>
#include <linux/fs.h> #include <linux/fs.h>
...@@ -14,7 +15,7 @@ ...@@ -14,7 +15,7 @@
#include <asm/ioctls.h> #include <asm/ioctls.h>
#include "fanotify.h" extern const struct fsnotify_ops fanotify_fsnotify_ops;
static struct kmem_cache *fanotify_mark_cache __read_mostly; static struct kmem_cache *fanotify_mark_cache __read_mostly;
...@@ -102,7 +103,7 @@ static ssize_t fill_event_metadata(struct fsnotify_group *group, ...@@ -102,7 +103,7 @@ static ssize_t fill_event_metadata(struct fsnotify_group *group,
metadata->event_len = FAN_EVENT_METADATA_LEN; metadata->event_len = FAN_EVENT_METADATA_LEN;
metadata->vers = FANOTIFY_METADATA_VERSION; metadata->vers = FANOTIFY_METADATA_VERSION;
metadata->mask = fanotify_outgoing_mask(event->mask); metadata->mask = event->mask & FAN_ALL_OUTGOING_EVENTS;
metadata->pid = pid_vnr(event->tgid); metadata->pid = pid_vnr(event->tgid);
metadata->fd = create_fd(group, event); metadata->fd = create_fd(group, event);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment