Commit 34708a0c authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Jonathan Cameron

Staging: iio: accel: sca3000: Fixed NULL comparison style

The variable u8 **rx_p, is a pointer-to-pointer and hence the check
should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which
was incorrect:
CHECK: Comparison to NULL could be written "!rx_p"
+       if (*rx_p == NULL) {
Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 6e17c98a
...@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st, ...@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
} }
}; };
*rx_p = kmalloc(len, GFP_KERNEL); *rx_p = kmalloc(len, GFP_KERNEL);
if (*rx_p == NULL) { if (!*rx_p) {
ret = -ENOMEM; ret = -ENOMEM;
goto error_ret; goto error_ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment