Commit 357b41ca authored by Matthieu Baerts's avatar Matthieu Baerts Committed by David S. Miller

mptcp: select CRYPTO

Without this modification and if CRYPTO is not selected, we have this
warning:

  WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
    Depends on [n]: CRYPTO [=n]
    Selected by [y]:
    - MPTCP [=y] && NET [=y] && INET [=y]

MPTCP selects CRYPTO_LIB_SHA256 which seems to depend on CRYPTO. CRYPTO
is now selected to avoid this issue.

Even though the config system prints that warning, it looks like
sha256.c is compiled and linked even without CONFIG_CRYPTO. Since MPTCP
will end up needing CONFIG_CRYPTO anyway in future commits -- currently
in preparation for net-next -- we propose to add it now to fix the
warning.

The dependency in the config system comes from the fact that
CRYPTO_LIB_SHA256 is defined in "lib/crypto/Kconfig" which is sourced
from "crypto/Kconfig" only if CRYPTO is selected.

Fixes: 65492c5a (mptcp: move from sha1 (v0) to sha256 (v1))
Signed-off-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c230978f
...@@ -4,6 +4,7 @@ config MPTCP ...@@ -4,6 +4,7 @@ config MPTCP
depends on INET depends on INET
select SKB_EXTENSIONS select SKB_EXTENSIONS
select CRYPTO_LIB_SHA256 select CRYPTO_LIB_SHA256
select CRYPTO
help help
Multipath TCP (MPTCP) connections send and receive data over multiple Multipath TCP (MPTCP) connections send and receive data over multiple
subflows in order to utilize multiple network paths. Each subflow subflows in order to utilize multiple network paths. Each subflow
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment