Commit 36f3b4f6 authored by Al Viro's avatar Al Viro

pull security_inode_follow_link() into __do_follow_link()

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 086e183a
...@@ -754,6 +754,13 @@ __do_follow_link(const struct path *link, struct nameidata *nd, void **p) ...@@ -754,6 +754,13 @@ __do_follow_link(const struct path *link, struct nameidata *nd, void **p)
if (link->mnt == nd->path.mnt) if (link->mnt == nd->path.mnt)
mntget(link->mnt); mntget(link->mnt);
error = security_inode_follow_link(link->dentry, nd);
if (error) {
*p = ERR_PTR(error); /* no ->put_link(), please */
path_put(&nd->path);
return error;
}
nd->last_type = LAST_BIND; nd->last_type = LAST_BIND;
*p = dentry->d_inode->i_op->follow_link(dentry, nd); *p = dentry->d_inode->i_op->follow_link(dentry, nd);
error = PTR_ERR(*p); error = PTR_ERR(*p);
...@@ -791,9 +798,6 @@ static inline int do_follow_link(struct inode *inode, struct path *path, struct ...@@ -791,9 +798,6 @@ static inline int do_follow_link(struct inode *inode, struct path *path, struct
goto loop; goto loop;
BUG_ON(nd->depth >= MAX_NESTED_LINKS); BUG_ON(nd->depth >= MAX_NESTED_LINKS);
cond_resched(); cond_resched();
err = security_inode_follow_link(path->dentry, nd);
if (err)
goto loop;
current->link_count++; current->link_count++;
current->total_link_count++; current->total_link_count++;
nd->depth++; nd->depth++;
...@@ -2420,9 +2424,6 @@ struct file *do_filp_open(int dfd, const char *pathname, ...@@ -2420,9 +2424,6 @@ struct file *do_filp_open(int dfd, const char *pathname,
* just set LAST_BIND. * just set LAST_BIND.
*/ */
nd.flags |= LOOKUP_PARENT; nd.flags |= LOOKUP_PARENT;
error = security_inode_follow_link(link.dentry, &nd);
if (error)
goto exit_dput;
error = __do_follow_link(&link, &nd, &cookie); error = __do_follow_link(&link, &nd, &cookie);
if (unlikely(error)) { if (unlikely(error)) {
if (!IS_ERR(cookie) && linki->i_op->put_link) if (!IS_ERR(cookie) && linki->i_op->put_link)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment