Commit 3d035237 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Nicholas Bellinger

target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()

When setting up an ALUA target port group with an invalid ID the
error message

kstrtoul() returned -22 for tg_pt_gp_id

is displayed, which is not really helpful.
Convert it to something sane.
And while we're at it, join the messages onto a single line.
Signed-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarBart van Assche <bart.vanassche@sandisk.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent c0dcafd8
...@@ -2677,13 +2677,13 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item, ...@@ -2677,13 +2677,13 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
ret = kstrtoul(page, 0, &tg_pt_gp_id); ret = kstrtoul(page, 0, &tg_pt_gp_id);
if (ret < 0) { if (ret < 0) {
pr_err("kstrtoul() returned %d for" pr_err("ALUA tg_pt_gp_id: invalid value '%s' for tg_pt_gp_id\n",
" tg_pt_gp_id\n", ret); page);
return ret; return ret;
} }
if (tg_pt_gp_id > 0x0000ffff) { if (tg_pt_gp_id > 0x0000ffff) {
pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum:" pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum: 0x0000ffff\n",
" 0x0000ffff\n", tg_pt_gp_id); tg_pt_gp_id);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment