Commit 3db272c0 authored by Li Zefan's avatar Li Zefan Committed by Ingo Molnar

perf cgroup: Fix leak of file reference count

In perf_cgroup_connect(), fput_light() is missing in a failure path.
Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Acked-by: default avatarStephane Eranian <eranian@google.com>
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <4D6F3461.6060406@cn.fujitsu.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 940c5b29
...@@ -404,8 +404,10 @@ static inline int perf_cgroup_connect(int fd, struct perf_event *event, ...@@ -404,8 +404,10 @@ static inline int perf_cgroup_connect(int fd, struct perf_event *event,
return -EBADF; return -EBADF;
css = cgroup_css_from_dir(file, perf_subsys_id); css = cgroup_css_from_dir(file, perf_subsys_id);
if (IS_ERR(css)) if (IS_ERR(css)) {
return PTR_ERR(css); ret = PTR_ERR(css);
goto out;
}
cgrp = container_of(css, struct perf_cgroup, css); cgrp = container_of(css, struct perf_cgroup, css);
event->cgrp = cgrp; event->cgrp = cgrp;
...@@ -422,6 +424,7 @@ static inline int perf_cgroup_connect(int fd, struct perf_event *event, ...@@ -422,6 +424,7 @@ static inline int perf_cgroup_connect(int fd, struct perf_event *event,
/* must be done before we fput() the file */ /* must be done before we fput() the file */
perf_get_cgroup(event); perf_get_cgroup(event);
} }
out:
fput_light(file, fput_needed); fput_light(file, fput_needed);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment