Commit 3def84b3 authored by Jani Nikula's avatar Jani Nikula Committed by Daniel Vetter

drm/i915/dp: promote clock recovery failures to DRM_ERROR

If channel equalization succeeds, there's no indication something went
wrong in clock recovery (unless debug is enabled). We should shout about
the failures and fix them instead of hiding them under the carpet.

This has allowed bugs like [1] stay dormant for a long time.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=70117Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent e1553faa
...@@ -2507,7 +2507,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) ...@@ -2507,7 +2507,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
if (i == intel_dp->lane_count) { if (i == intel_dp->lane_count) {
++loop_tries; ++loop_tries;
if (loop_tries == 5) { if (loop_tries == 5) {
DRM_DEBUG_KMS("too many full retries, give up\n"); DRM_ERROR("too many full retries, give up\n");
break; break;
} }
intel_dp_reset_link_train(intel_dp, &DP, intel_dp_reset_link_train(intel_dp, &DP,
...@@ -2521,7 +2521,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) ...@@ -2521,7 +2521,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) { if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) {
++voltage_tries; ++voltage_tries;
if (voltage_tries == 5) { if (voltage_tries == 5) {
DRM_DEBUG_KMS("too many voltage retries, give up\n"); DRM_ERROR("too many voltage retries, give up\n");
break; break;
} }
} else } else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment