Commit 40f99081 authored by Alexander Viro's avatar Alexander Viro Committed by Linus Torvalds

[PATCH] callout removal: 8xx_uart

callout removal: 8xx_uart
parent 9ef4b4f9
...@@ -85,7 +85,7 @@ static char *serial_version = "0.03"; ...@@ -85,7 +85,7 @@ static char *serial_version = "0.03";
static DECLARE_TASK_QUEUE(tq_serial); static DECLARE_TASK_QUEUE(tq_serial);
static struct tty_driver serial_driver, callout_driver; static struct tty_driver serial_driver;
static int serial_refcount; static int serial_refcount;
static int serial_console_setup(struct console *co, char *options); static int serial_console_setup(struct console *co, char *options);
...@@ -199,8 +199,6 @@ typedef struct serial_info { ...@@ -199,8 +199,6 @@ typedef struct serial_info {
unsigned long event; unsigned long event;
unsigned long last_active; unsigned long last_active;
int blocked_open; /* # of blocked opens */ int blocked_open; /* # of blocked opens */
long session; /* Session of opening process */
long pgrp; /* pgrp of opening process */
struct tq_struct tqueue; struct tq_struct tqueue;
struct tq_struct tqueue_hangup; struct tq_struct tqueue_hangup;
wait_queue_head_t open_wait; wait_queue_head_t open_wait;
...@@ -590,8 +588,7 @@ static _INLINE_ void check_modem_status(struct async_struct *info) ...@@ -590,8 +588,7 @@ static _INLINE_ void check_modem_status(struct async_struct *info)
#endif #endif
if (status & UART_MSR_DCD) if (status & UART_MSR_DCD)
wake_up_interruptible(&info->open_wait); wake_up_interruptible(&info->open_wait);
else if (!((info->flags & ASYNC_CALLOUT_ACTIVE) && else {
(info->flags & ASYNC_CALLOUT_NOHUP))) {
#ifdef SERIAL_DEBUG_OPEN #ifdef SERIAL_DEBUG_OPEN
printk("scheduling hangup..."); printk("scheduling hangup...");
#endif #endif
...@@ -1714,8 +1711,6 @@ static void rs_8xx_close(struct tty_struct *tty, struct file * filp) ...@@ -1714,8 +1711,6 @@ static void rs_8xx_close(struct tty_struct *tty, struct file * filp)
*/ */
if (info->flags & ASYNC_NORMAL_ACTIVE) if (info->flags & ASYNC_NORMAL_ACTIVE)
info->state->normal_termios = *tty->termios; info->state->normal_termios = *tty->termios;
if (info->flags & ASYNC_CALLOUT_ACTIVE)
info->state->callout_termios = *tty->termios;
/* /*
* Now we wait for the transmit buffer to clear; and we notify * Now we wait for the transmit buffer to clear; and we notify
* the line discipline to only process XON/XOFF characters. * the line discipline to only process XON/XOFF characters.
...@@ -1764,8 +1759,7 @@ static void rs_8xx_close(struct tty_struct *tty, struct file * filp) ...@@ -1764,8 +1759,7 @@ static void rs_8xx_close(struct tty_struct *tty, struct file * filp)
} }
wake_up_interruptible(&info->open_wait); wake_up_interruptible(&info->open_wait);
} }
info->flags &= ~(ASYNC_NORMAL_ACTIVE|ASYNC_CALLOUT_ACTIVE| info->flags &= ~(ASYNC_NORMAL_ACTIVE|ASYNC_CLOSING);
ASYNC_CLOSING);
wake_up_interruptible(&info->close_wait); wake_up_interruptible(&info->close_wait);
MOD_DEC_USE_COUNT; MOD_DEC_USE_COUNT;
restore_flags(flags); restore_flags(flags);
...@@ -1858,7 +1852,7 @@ static void rs_8xx_hangup(struct tty_struct *tty) ...@@ -1858,7 +1852,7 @@ static void rs_8xx_hangup(struct tty_struct *tty)
shutdown(info); shutdown(info);
info->event = 0; info->event = 0;
state->count = 0; state->count = 0;
info->flags &= ~(ASYNC_NORMAL_ACTIVE|ASYNC_CALLOUT_ACTIVE); info->flags &= ~ASYNC_NORMAL_ACTIVE;
info->tty = 0; info->tty = 0;
wake_up_interruptible(&info->open_wait); wake_up_interruptible(&info->open_wait);
} }
...@@ -1896,25 +1890,6 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp, ...@@ -1896,25 +1890,6 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
#endif #endif
} }
/*
* If this is a callout device, then just make sure the normal
* device isn't being used.
*/
if (tty->driver->subtype == SERIAL_TYPE_CALLOUT) {
if (info->flags & ASYNC_NORMAL_ACTIVE)
return -EBUSY;
if ((info->flags & ASYNC_CALLOUT_ACTIVE) &&
(info->flags & ASYNC_SESSION_LOCKOUT) &&
(info->session != current->session))
return -EBUSY;
if ((info->flags & ASYNC_CALLOUT_ACTIVE) &&
(info->flags & ASYNC_PGRP_LOCKOUT) &&
(info->pgrp != current->pgrp))
return -EBUSY;
info->flags |= ASYNC_CALLOUT_ACTIVE;
return 0;
}
/* /*
* If non-blocking mode is set, or the port is not enabled, * If non-blocking mode is set, or the port is not enabled,
* then make the check up front and then exit. * then make the check up front and then exit.
...@@ -1924,19 +1899,12 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp, ...@@ -1924,19 +1899,12 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
if ((filp->f_flags & O_NONBLOCK) || if ((filp->f_flags & O_NONBLOCK) ||
(tty->flags & (1 << TTY_IO_ERROR)) || (tty->flags & (1 << TTY_IO_ERROR)) ||
!(info->state->smc_scc_num & NUM_IS_SCC)) { !(info->state->smc_scc_num & NUM_IS_SCC)) {
if (info->flags & ASYNC_CALLOUT_ACTIVE)
return -EBUSY;
info->flags |= ASYNC_NORMAL_ACTIVE; info->flags |= ASYNC_NORMAL_ACTIVE;
return 0; return 0;
} }
if (info->flags & ASYNC_CALLOUT_ACTIVE) {
if (state->normal_termios.c_cflag & CLOCAL)
do_clocal = 1;
} else {
if (tty->termios->c_cflag & CLOCAL) if (tty->termios->c_cflag & CLOCAL)
do_clocal = 1; do_clocal = 1;
}
/* /*
* Block waiting for the carrier detect and the line to become * Block waiting for the carrier detect and the line to become
...@@ -1959,8 +1927,7 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp, ...@@ -1959,8 +1927,7 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
info->blocked_open++; info->blocked_open++;
while (1) { while (1) {
cli(); cli();
if (!(info->flags & ASYNC_CALLOUT_ACTIVE) && if ((tty->termios->c_cflag & CBAUD))
(tty->termios->c_cflag & CBAUD))
serial_out(info, UART_MCR, serial_out(info, UART_MCR,
serial_inp(info, UART_MCR) | serial_inp(info, UART_MCR) |
(UART_MCR_DTR | UART_MCR_RTS)); (UART_MCR_DTR | UART_MCR_RTS));
...@@ -1978,8 +1945,7 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp, ...@@ -1978,8 +1945,7 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
#endif #endif
break; break;
} }
if (!(info->flags & ASYNC_CALLOUT_ACTIVE) && if (!(info->flags & ASYNC_CLOSING) &&
!(info->flags & ASYNC_CLOSING) &&
(do_clocal || (serial_in(info, UART_MSR) & (do_clocal || (serial_in(info, UART_MSR) &
UART_MSR_DCD))) UART_MSR_DCD)))
break; break;
...@@ -2070,16 +2036,10 @@ static int rs_8xx_open(struct tty_struct *tty, struct file * filp) ...@@ -2070,16 +2036,10 @@ static int rs_8xx_open(struct tty_struct *tty, struct file * filp)
if ((info->state->count == 1) && if ((info->state->count == 1) &&
(info->flags & ASYNC_SPLIT_TERMIOS)) { (info->flags & ASYNC_SPLIT_TERMIOS)) {
if (tty->driver->subtype == SERIAL_TYPE_NORMAL)
*tty->termios = info->state->normal_termios; *tty->termios = info->state->normal_termios;
else
*tty->termios = info->state->callout_termios;
change_speed(info); change_speed(info);
} }
info->session = current->session;
info->pgrp = current->pgrp;
#ifdef SERIAL_DEBUG_OPEN #ifdef SERIAL_DEBUG_OPEN
printk("rs_open %s successful...", tty->name); printk("rs_open %s successful...", tty->name);
#endif #endif
...@@ -2597,25 +2557,8 @@ int __init rs_8xx_init(void) ...@@ -2597,25 +2557,8 @@ int __init rs_8xx_init(void)
serial_driver.wait_until_sent = rs_8xx_wait_until_sent; serial_driver.wait_until_sent = rs_8xx_wait_until_sent;
serial_driver.read_proc = rs_8xx_read_proc; serial_driver.read_proc = rs_8xx_read_proc;
/*
* The callout device is just like normal device except for
* major number and the subtype code.
*/
callout_driver = serial_driver;
#ifdef CONFIG_DEVFS_FS
callout_driver.name = "cua/";
#else
callout_driver.name = "cua";
#endif
callout_driver.major = TTYAUX_MAJOR;
callout_driver.subtype = SERIAL_TYPE_CALLOUT;
callout_driver.read_proc = 0;
callout_driver.proc_entry = 0;
if (tty_register_driver(&serial_driver)) if (tty_register_driver(&serial_driver))
panic("Couldn't register serial driver\n"); panic("Couldn't register serial driver\n");
if (tty_register_driver(&callout_driver))
panic("Couldn't register callout driver\n");
cp = cpmp; /* Get pointer to Communication Processor */ cp = cpmp; /* Get pointer to Communication Processor */
immap = (immap_t *)IMAP_ADDR; /* and to internal registers */ immap = (immap_t *)IMAP_ADDR; /* and to internal registers */
...@@ -2675,7 +2618,6 @@ int __init rs_8xx_init(void) ...@@ -2675,7 +2618,6 @@ int __init rs_8xx_init(void)
state->custom_divisor = 0; state->custom_divisor = 0;
state->close_delay = 5*HZ/10; state->close_delay = 5*HZ/10;
state->closing_wait = 30*HZ; state->closing_wait = 30*HZ;
state->callout_termios = callout_driver.init_termios;
state->normal_termios = serial_driver.init_termios; state->normal_termios = serial_driver.init_termios;
state->icount.cts = state->icount.dsr = state->icount.cts = state->icount.dsr =
state->icount.rng = state->icount.dcd = 0; state->icount.rng = state->icount.dcd = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment