Commit 448a2413 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller

Revert "r8169: use netif_receive_skb_list batching"

This reverts commit 6578229d.
netif_receive_skb_list() doesn't support GRO, therefore we may have
scenarios with decreased performance. See discussion here [0].

[0] https://marc.info/?t=155403847400001&r=1&w=2Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6fee16d
...@@ -6426,7 +6426,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget ...@@ -6426,7 +6426,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
{ {
unsigned int cur_rx, rx_left; unsigned int cur_rx, rx_left;
unsigned int count; unsigned int count;
LIST_HEAD(rx_list);
cur_rx = tp->cur_rx; cur_rx = tp->cur_rx;
...@@ -6502,7 +6501,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget ...@@ -6502,7 +6501,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
if (skb->pkt_type == PACKET_MULTICAST) if (skb->pkt_type == PACKET_MULTICAST)
dev->stats.multicast++; dev->stats.multicast++;
list_add_tail(&skb->list, &rx_list); napi_gro_receive(&tp->napi, skb);
u64_stats_update_begin(&tp->rx_stats.syncp); u64_stats_update_begin(&tp->rx_stats.syncp);
tp->rx_stats.packets++; tp->rx_stats.packets++;
...@@ -6517,8 +6516,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget ...@@ -6517,8 +6516,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
count = cur_rx - tp->cur_rx; count = cur_rx - tp->cur_rx;
tp->cur_rx = cur_rx; tp->cur_rx = cur_rx;
netif_receive_skb_list(&rx_list);
return count; return count;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment