Commit 4afe6495 authored by Wang Xiaoqiang's avatar Wang Xiaoqiang Committed by Steven Rostedt

tracing: Don't use the address of the buffer array name in copy_from_user

With the following code snippet:

    ...
    char buf[64];
    ...
    if (copy_from_user(&buf, ubuf, cnt))
    ...

Even though the value of "&buf" equals "buf", but there is no need
to get the address of the "buf" again. Use "buf" instead of "&buf".

Link: http://lkml.kernel.org/r/20160418152329.18b72bea@debianSigned-off-by: default avatarWang Xiaoqiang <wangxq10@lzu.edu.cn>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 6e4cf657
...@@ -3664,7 +3664,7 @@ tracing_trace_options_write(struct file *filp, const char __user *ubuf, ...@@ -3664,7 +3664,7 @@ tracing_trace_options_write(struct file *filp, const char __user *ubuf,
if (cnt >= sizeof(buf)) if (cnt >= sizeof(buf))
return -EINVAL; return -EINVAL;
if (copy_from_user(&buf, ubuf, cnt)) if (copy_from_user(buf, ubuf, cnt))
return -EFAULT; return -EFAULT;
buf[cnt] = 0; buf[cnt] = 0;
...@@ -4537,7 +4537,7 @@ tracing_set_trace_write(struct file *filp, const char __user *ubuf, ...@@ -4537,7 +4537,7 @@ tracing_set_trace_write(struct file *filp, const char __user *ubuf,
if (cnt > MAX_TRACER_SIZE) if (cnt > MAX_TRACER_SIZE)
cnt = MAX_TRACER_SIZE; cnt = MAX_TRACER_SIZE;
if (copy_from_user(&buf, ubuf, cnt)) if (copy_from_user(buf, ubuf, cnt))
return -EFAULT; return -EFAULT;
buf[cnt] = 0; buf[cnt] = 0;
...@@ -5327,7 +5327,7 @@ static ssize_t tracing_clock_write(struct file *filp, const char __user *ubuf, ...@@ -5327,7 +5327,7 @@ static ssize_t tracing_clock_write(struct file *filp, const char __user *ubuf,
if (cnt >= sizeof(buf)) if (cnt >= sizeof(buf))
return -EINVAL; return -EINVAL;
if (copy_from_user(&buf, ubuf, cnt)) if (copy_from_user(buf, ubuf, cnt))
return -EFAULT; return -EFAULT;
buf[cnt] = 0; buf[cnt] = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment