Commit 517663ed authored by Steven Rostedt (VMware)'s avatar Steven Rostedt (VMware) Committed by Linus Torvalds

mm/page-writeback.c: place "not" inside of unlikely() statement in wb_domain_writeout_inc()

The likely/unlikely profiler noticed that the unlikely statement in
wb_domain_writeout_inc() is constantly wrong.  This is due to the "not"
(!) being outside the unlikely statement.  It is likely that
dom->period_time will be set, but unlikely that it wont be.  Move the
not into the unlikely statement.

Link: http://lkml.kernel.org/r/20170206120035.3c2e2b91@gandalf.local.homeSigned-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c137a275
...@@ -580,7 +580,7 @@ static void wb_domain_writeout_inc(struct wb_domain *dom, ...@@ -580,7 +580,7 @@ static void wb_domain_writeout_inc(struct wb_domain *dom,
__fprop_inc_percpu_max(&dom->completions, completions, __fprop_inc_percpu_max(&dom->completions, completions,
max_prop_frac); max_prop_frac);
/* First event after period switching was turned off? */ /* First event after period switching was turned off? */
if (!unlikely(dom->period_time)) { if (unlikely(!dom->period_time)) {
/* /*
* We can race with other __bdi_writeout_inc calls here but * We can race with other __bdi_writeout_inc calls here but
* it does not cause any harm since the resulting time when * it does not cause any harm since the resulting time when
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment