Commit 53a4befa authored by Axel Lin's avatar Axel Lin Committed by Liam Girdwood

regulator: max8660 - fix a memory leak in max8660_remove()

In max8660_probe(), we allocate memory for max660.
In max8660_remove(), current implementation only free rdev
which is a member of struct max8660.
Thus, there is a small memory leak when we unload the module.

This patch fixes the memory leak by passing max660 to i2c clientdata,
and properly kfree(max8660) in max8660_remove().
Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 7c4c25e4
...@@ -450,7 +450,7 @@ static int __devinit max8660_probe(struct i2c_client *client, ...@@ -450,7 +450,7 @@ static int __devinit max8660_probe(struct i2c_client *client,
} }
} }
i2c_set_clientdata(client, rdev); i2c_set_clientdata(client, max8660);
dev_info(&client->dev, "Maxim 8660/8661 regulator driver loaded\n"); dev_info(&client->dev, "Maxim 8660/8661 regulator driver loaded\n");
return 0; return 0;
...@@ -465,13 +465,13 @@ static int __devinit max8660_probe(struct i2c_client *client, ...@@ -465,13 +465,13 @@ static int __devinit max8660_probe(struct i2c_client *client,
static int __devexit max8660_remove(struct i2c_client *client) static int __devexit max8660_remove(struct i2c_client *client)
{ {
struct regulator_dev **rdev = i2c_get_clientdata(client); struct max8660 *max8660 = i2c_get_clientdata(client);
int i; int i;
for (i = 0; i < MAX8660_V_END; i++) for (i = 0; i < MAX8660_V_END; i++)
if (rdev[i]) if (max8660->rdev[i])
regulator_unregister(rdev[i]); regulator_unregister(max8660->rdev[i]);
kfree(rdev); kfree(max8660);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment