Commit 5509ac65 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Alex Deucher

drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the
counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9ba8923c
...@@ -1383,11 +1383,12 @@ long amdgpu_drm_ioctl(struct file *filp, ...@@ -1383,11 +1383,12 @@ long amdgpu_drm_ioctl(struct file *filp,
dev = file_priv->minor->dev; dev = file_priv->minor->dev;
ret = pm_runtime_get_sync(dev->dev); ret = pm_runtime_get_sync(dev->dev);
if (ret < 0) if (ret < 0)
return ret; goto out;
ret = drm_ioctl(filp, cmd, arg); ret = drm_ioctl(filp, cmd, arg);
pm_runtime_mark_last_busy(dev->dev); pm_runtime_mark_last_busy(dev->dev);
out:
pm_runtime_put_autosuspend(dev->dev); pm_runtime_put_autosuspend(dev->dev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment