Commit 556030f0 authored by Bibby Hsieh's avatar Bibby Hsieh Committed by Matthias Brugger

soc: mediatek: cmdq: change the type of input parameter

According to the cmdq hardware design, the subsys is u8,
the offset is u16 and the event id is u16.
This patch changes the type of subsys, offset and event id
to the correct type.
Signed-off-by: default avatarBibby Hsieh <bibby.hsieh@mediatek.com>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent 1a92f989
...@@ -136,7 +136,7 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, ...@@ -136,7 +136,7 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code,
return 0; return 0;
} }
int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value) int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value)
{ {
u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) | u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) |
(subsys << CMDQ_SUBSYS_SHIFT); (subsys << CMDQ_SUBSYS_SHIFT);
...@@ -145,8 +145,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value) ...@@ -145,8 +145,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value)
} }
EXPORT_SYMBOL(cmdq_pkt_write); EXPORT_SYMBOL(cmdq_pkt_write);
int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys, int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
u32 offset, u32 value, u32 mask) u16 offset, u32 value, u32 mask)
{ {
u32 offset_mask = offset; u32 offset_mask = offset;
int err = 0; int err = 0;
...@@ -161,7 +161,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys, ...@@ -161,7 +161,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys,
} }
EXPORT_SYMBOL(cmdq_pkt_write_mask); EXPORT_SYMBOL(cmdq_pkt_write_mask);
int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u32 event) int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event)
{ {
u32 arg_b; u32 arg_b;
...@@ -181,7 +181,7 @@ int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u32 event) ...@@ -181,7 +181,7 @@ int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u32 event)
} }
EXPORT_SYMBOL(cmdq_pkt_wfe); EXPORT_SYMBOL(cmdq_pkt_wfe);
int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u32 event) int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event)
{ {
if (event >= CMDQ_MAX_EVENT) if (event >= CMDQ_MAX_EVENT)
return -EINVAL; return -EINVAL;
......
...@@ -69,7 +69,7 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt); ...@@ -69,7 +69,7 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt);
* *
* Return: 0 for success; else the error code is returned * Return: 0 for success; else the error code is returned
*/ */
int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value); int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value);
/** /**
* cmdq_pkt_write_mask() - append write command with mask to the CMDQ packet * cmdq_pkt_write_mask() - append write command with mask to the CMDQ packet
...@@ -81,8 +81,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value); ...@@ -81,8 +81,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value);
* *
* Return: 0 for success; else the error code is returned * Return: 0 for success; else the error code is returned
*/ */
int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys, int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
u32 offset, u32 value, u32 mask); u16 offset, u32 value, u32 mask);
/** /**
* cmdq_pkt_wfe() - append wait for event command to the CMDQ packet * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet
...@@ -91,7 +91,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys, ...@@ -91,7 +91,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys,
* *
* Return: 0 for success; else the error code is returned * Return: 0 for success; else the error code is returned
*/ */
int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u32 event); int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event);
/** /**
* cmdq_pkt_clear_event() - append clear event command to the CMDQ packet * cmdq_pkt_clear_event() - append clear event command to the CMDQ packet
...@@ -100,7 +100,7 @@ int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u32 event); ...@@ -100,7 +100,7 @@ int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u32 event);
* *
* Return: 0 for success; else the error code is returned * Return: 0 for success; else the error code is returned
*/ */
int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u32 event); int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event);
/** /**
* cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment