Commit 56c54b25 authored by Tao Zhou's avatar Tao Zhou Committed by Alex Deucher

drm/amdgpu: remove ih_info parameter of umc_ras_late_init

umc_ras_late_init can get the info by itself
Signed-off-by: default avatarTao Zhou <tao.zhou1@amd.com>
Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e536c818
...@@ -23,17 +23,16 @@ ...@@ -23,17 +23,16 @@
#include "amdgpu_ras.h" #include "amdgpu_ras.h"
int amdgpu_umc_ras_late_init(struct amdgpu_device *adev, void *ras_ih_info) int amdgpu_umc_ras_late_init(struct amdgpu_device *adev)
{ {
int r; int r;
struct ras_ih_if *ih_info = (struct ras_ih_if *)ras_ih_info;
struct ras_fs_if fs_info = { struct ras_fs_if fs_info = {
.sysfs_name = "umc_err_count", .sysfs_name = "umc_err_count",
.debugfs_name = "umc_err_inject", .debugfs_name = "umc_err_inject",
}; };
struct ras_ih_if ih_info = {
if (!ih_info) .cb = amdgpu_umc_process_ras_data_cb,
return -EINVAL; };
if (!adev->umc.ras_if) { if (!adev->umc.ras_if) {
adev->umc.ras_if = adev->umc.ras_if =
...@@ -45,10 +44,10 @@ int amdgpu_umc_ras_late_init(struct amdgpu_device *adev, void *ras_ih_info) ...@@ -45,10 +44,10 @@ int amdgpu_umc_ras_late_init(struct amdgpu_device *adev, void *ras_ih_info)
adev->umc.ras_if->sub_block_index = 0; adev->umc.ras_if->sub_block_index = 0;
strcpy(adev->umc.ras_if->name, "umc"); strcpy(adev->umc.ras_if->name, "umc");
} }
ih_info->head = fs_info.head = *adev->umc.ras_if; ih_info.head = fs_info.head = *adev->umc.ras_if;
r = amdgpu_ras_late_init(adev, adev->umc.ras_if, r = amdgpu_ras_late_init(adev, adev->umc.ras_if,
&fs_info, ih_info); &fs_info, &ih_info);
if (r) if (r)
goto free; goto free;
...@@ -68,7 +67,7 @@ int amdgpu_umc_ras_late_init(struct amdgpu_device *adev, void *ras_ih_info) ...@@ -68,7 +67,7 @@ int amdgpu_umc_ras_late_init(struct amdgpu_device *adev, void *ras_ih_info)
return 0; return 0;
late_fini: late_fini:
amdgpu_ras_late_fini(adev, adev->umc.ras_if, ih_info); amdgpu_ras_late_fini(adev, adev->umc.ras_if, &ih_info);
free: free:
kfree(adev->umc.ras_if); kfree(adev->umc.ras_if);
adev->umc.ras_if = NULL; adev->umc.ras_if = NULL;
......
...@@ -55,7 +55,7 @@ ...@@ -55,7 +55,7 @@
struct amdgpu_umc_funcs { struct amdgpu_umc_funcs {
void (*err_cnt_init)(struct amdgpu_device *adev); void (*err_cnt_init)(struct amdgpu_device *adev);
int (*ras_late_init)(struct amdgpu_device *adev, void *ras_ih_info); int (*ras_late_init)(struct amdgpu_device *adev);
void (*query_ras_error_count)(struct amdgpu_device *adev, void (*query_ras_error_count)(struct amdgpu_device *adev,
void *ras_error_status); void *ras_error_status);
void (*query_ras_error_address)(struct amdgpu_device *adev, void (*query_ras_error_address)(struct amdgpu_device *adev,
...@@ -82,7 +82,7 @@ struct amdgpu_umc { ...@@ -82,7 +82,7 @@ struct amdgpu_umc {
const struct amdgpu_umc_funcs *funcs; const struct amdgpu_umc_funcs *funcs;
}; };
int amdgpu_umc_ras_late_init(struct amdgpu_device *adev, void *ras_ih_info); int amdgpu_umc_ras_late_init(struct amdgpu_device *adev);
int amdgpu_umc_process_ras_data_cb(struct amdgpu_device *adev, int amdgpu_umc_process_ras_data_cb(struct amdgpu_device *adev,
void *ras_error_status, void *ras_error_status,
struct amdgpu_iv_entry *entry); struct amdgpu_iv_entry *entry);
......
...@@ -740,12 +740,9 @@ static int gmc_v9_0_ecc_late_init(void *handle) ...@@ -740,12 +740,9 @@ static int gmc_v9_0_ecc_late_init(void *handle)
{ {
int r; int r;
struct amdgpu_device *adev = (struct amdgpu_device *)handle; struct amdgpu_device *adev = (struct amdgpu_device *)handle;
struct ras_ih_if umc_ih_info = {
.cb = amdgpu_umc_process_ras_data_cb,
};
if (adev->umc.funcs && adev->umc.funcs->ras_late_init) { if (adev->umc.funcs && adev->umc.funcs->ras_late_init) {
r = adev->umc.funcs->ras_late_init(adev, &umc_ih_info); r = adev->umc.funcs->ras_late_init(adev);
if (r) if (r)
return r; return r;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment