Commit 58818a77 authored by Dimitris Papastamos's avatar Dimitris Papastamos Committed by Mark Brown

ASoC: soc-core: Replace use of strncpy() with strlcpy()

By using strncpy() if the source string does not have a null byte in the
first n bytes, then the destination string is not null-terminated.
This can be fixed in a two-step process by manually null-terminating the
array after the use of strncpy() or by using strlcpy().
Signed-off-by: default avatarDimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 589c3563
...@@ -3183,7 +3183,7 @@ static inline char *fmt_single_name(struct device *dev, int *id) ...@@ -3183,7 +3183,7 @@ static inline char *fmt_single_name(struct device *dev, int *id)
if (dev_name(dev) == NULL) if (dev_name(dev) == NULL)
return NULL; return NULL;
strncpy(name, dev_name(dev), NAME_SIZE); strlcpy(name, dev_name(dev), NAME_SIZE);
/* are we a "%s.%d" name (platform and SPI components) */ /* are we a "%s.%d" name (platform and SPI components) */
found = strstr(name, dev->driver->name); found = strstr(name, dev->driver->name);
...@@ -3206,7 +3206,7 @@ static inline char *fmt_single_name(struct device *dev, int *id) ...@@ -3206,7 +3206,7 @@ static inline char *fmt_single_name(struct device *dev, int *id)
/* sanitize component name for DAI link creation */ /* sanitize component name for DAI link creation */
snprintf(tmp, NAME_SIZE, "%s.%s", dev->driver->name, name); snprintf(tmp, NAME_SIZE, "%s.%s", dev->driver->name, name);
strncpy(name, tmp, NAME_SIZE); strlcpy(name, tmp, NAME_SIZE);
} else } else
*id = 0; *id = 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment