Commit 59714d65 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

get_task_comm(): return the result

It was dumb to make get_task_comm() return void.  Change it to return a
pointer to the resulting output for caller convenience.

Cc: Ulrich Drepper <drepper@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0ccf831c
...@@ -947,12 +947,13 @@ static void flush_old_files(struct files_struct * files) ...@@ -947,12 +947,13 @@ static void flush_old_files(struct files_struct * files)
spin_unlock(&files->file_lock); spin_unlock(&files->file_lock);
} }
void get_task_comm(char *buf, struct task_struct *tsk) char *get_task_comm(char *buf, struct task_struct *tsk)
{ {
/* buf must be at least sizeof(tsk->comm) in size */ /* buf must be at least sizeof(tsk->comm) in size */
task_lock(tsk); task_lock(tsk);
strncpy(buf, tsk->comm, sizeof(tsk->comm)); strncpy(buf, tsk->comm, sizeof(tsk->comm));
task_unlock(tsk); task_unlock(tsk);
return buf;
} }
void set_task_comm(struct task_struct *tsk, char *buf) void set_task_comm(struct task_struct *tsk, char *buf)
......
...@@ -1770,7 +1770,7 @@ extern long do_fork(unsigned long, unsigned long, struct pt_regs *, unsigned lon ...@@ -1770,7 +1770,7 @@ extern long do_fork(unsigned long, unsigned long, struct pt_regs *, unsigned lon
struct task_struct *fork_idle(int); struct task_struct *fork_idle(int);
extern void set_task_comm(struct task_struct *tsk, char *from); extern void set_task_comm(struct task_struct *tsk, char *from);
extern void get_task_comm(char *to, struct task_struct *tsk); extern char *get_task_comm(char *to, struct task_struct *tsk);
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
extern void wait_task_inactive(struct task_struct * p); extern void wait_task_inactive(struct task_struct * p);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment