Commit 5a730153 authored by Qiushi Wu's avatar Qiushi Wu Committed by David S. Miller

net: sun: fix missing release regions in cas_init_one().

In cas_init_one(), "pdev" is requested by "pci_request_regions", but it
was not released after a call of the function “pci_write_config_byte”
failed. Thus replace the jump target “err_write_cacheline” by
"err_out_free_res".

Fixes: 1f26dac3 ("[NET]: Add Sun Cassini driver.")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bf655ba2
...@@ -4963,7 +4963,7 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -4963,7 +4963,7 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
cas_cacheline_size)) { cas_cacheline_size)) {
dev_err(&pdev->dev, "Could not set PCI cache " dev_err(&pdev->dev, "Could not set PCI cache "
"line size\n"); "line size\n");
goto err_write_cacheline; goto err_out_free_res;
} }
} }
#endif #endif
...@@ -5136,7 +5136,6 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -5136,7 +5136,6 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
err_out_free_res: err_out_free_res:
pci_release_regions(pdev); pci_release_regions(pdev);
err_write_cacheline:
/* Try to restore it in case the error occurred after we /* Try to restore it in case the error occurred after we
* set it. * set it.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment