Commit 5c665aeb authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen

scsi: lpfc: don't dereference localport before it has been null checked

localport is being dereferenced to assign lport and then immediately
afterwards localport is being sanity checked to see if it is null.  Fix
this by only dereferencing localport until after it has been null
checked.

Detected by CoverityScan, CID#1463038 ("Dereference before null check")

Fixes: 3a8cefbfc5ee ("scsi: lpfc: Beef up stat counters for debug")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cc019a5a
...@@ -277,13 +277,13 @@ lpfc_nvme_info_show(struct device *dev, struct device_attribute *attr, ...@@ -277,13 +277,13 @@ lpfc_nvme_info_show(struct device *dev, struct device_attribute *attr,
} }
localport = vport->localport; localport = vport->localport;
lport = (struct lpfc_nvme_lport *)localport->private;
if (!localport) { if (!localport) {
len = snprintf(buf, PAGE_SIZE, len = snprintf(buf, PAGE_SIZE,
"NVME Initiator x%llx is not allocated\n", "NVME Initiator x%llx is not allocated\n",
wwn_to_u64(vport->fc_portname.u.wwn)); wwn_to_u64(vport->fc_portname.u.wwn));
return len; return len;
} }
lport = (struct lpfc_nvme_lport *)localport->private;
len = snprintf(buf, PAGE_SIZE, "NVME Initiator Enabled\n"); len = snprintf(buf, PAGE_SIZE, "NVME Initiator Enabled\n");
spin_lock_irq(shost->host_lock); spin_lock_irq(shost->host_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment