Commit 5cfc2aab authored by Rik van Riel's avatar Rik van Riel Committed by Marcelo Tosatti

KVM: handle last_boosted_vcpu = 0 case

If last_boosted_vcpu == 0, then we fall through all test cases and
may end up with all VCPUs pouncing on vcpu 0.  With a large enough
guest, this can result in enormous runqueue lock contention, which
can prevent vcpu0 from running, leading to a livelock.

Changing < to <= makes sure we properly handle that case.
Signed-off-by: default avatarRik van Riel <riel@redhat.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent 21b26c08
...@@ -1598,7 +1598,7 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me) ...@@ -1598,7 +1598,7 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me)
*/ */
for (pass = 0; pass < 2 && !yielded; pass++) { for (pass = 0; pass < 2 && !yielded; pass++) {
kvm_for_each_vcpu(i, vcpu, kvm) { kvm_for_each_vcpu(i, vcpu, kvm) {
if (!pass && i < last_boosted_vcpu) { if (!pass && i <= last_boosted_vcpu) {
i = last_boosted_vcpu; i = last_boosted_vcpu;
continue; continue;
} else if (pass && i > last_boosted_vcpu) } else if (pass && i > last_boosted_vcpu)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment