Commit 5d314a81 authored by Dan Carpenter's avatar Dan Carpenter Committed by John Johansen

apparmor: Fix an error code in aafs_create()

We accidentally forgot to set the error code on this path.  It means we
return NULL instead of an error pointer.  I looked through a bunch of
callers and I don't think it really causes a big issue, but the
documentation says we're supposed to return error pointers here.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSerge Hallyn <serge@hallyn.com>
Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
parent 86aea56f
...@@ -248,8 +248,10 @@ static struct dentry *aafs_create(const char *name, umode_t mode, ...@@ -248,8 +248,10 @@ static struct dentry *aafs_create(const char *name, umode_t mode,
inode_lock(dir); inode_lock(dir);
dentry = lookup_one_len(name, parent, strlen(name)); dentry = lookup_one_len(name, parent, strlen(name));
if (IS_ERR(dentry)) if (IS_ERR(dentry)) {
error = PTR_ERR(dentry);
goto fail_lock; goto fail_lock;
}
if (d_really_is_positive(dentry)) { if (d_really_is_positive(dentry)) {
error = -EEXIST; error = -EEXIST;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment