Commit 5d9c6b8a authored by Julia Lawall's avatar Julia Lawall Committed by Bjorn Helgaas

PCI: pnv_php: Add missing of_node_put()

The device node iterators perform an of_node_get() on each iteration, so a
jump out of the loop requires an of_node_put().

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent d22b3621
...@@ -220,12 +220,16 @@ static int pnv_php_populate_changeset(struct of_changeset *ocs, ...@@ -220,12 +220,16 @@ static int pnv_php_populate_changeset(struct of_changeset *ocs,
for_each_child_of_node(dn, child) { for_each_child_of_node(dn, child) {
ret = of_changeset_attach_node(ocs, child); ret = of_changeset_attach_node(ocs, child);
if (ret) if (ret) {
of_node_put(child);
break; break;
}
ret = pnv_php_populate_changeset(ocs, child); ret = pnv_php_populate_changeset(ocs, child);
if (ret) if (ret) {
of_node_put(child);
break; break;
}
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment