Commit 5df20401 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

staging: rtl8723bs: drop test

The test selects between two identical values, so it doesn't look useful.
It turns out that the tested expression can only be true anyway, so drop
the test, the corresponding parameter, and the corresponding argument at
the only call site.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1;
@@

* e ? e1 : e1
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 91c458b4
...@@ -1352,7 +1352,6 @@ static void _PHY_ReloadMACRegisters8723B( ...@@ -1352,7 +1352,6 @@ static void _PHY_ReloadMACRegisters8723B(
static void _PHY_PathADDAOn8723B( static void _PHY_PathADDAOn8723B(
struct adapter *padapter, struct adapter *padapter,
u32 *ADDAReg, u32 *ADDAReg,
bool isPathAOn,
bool is2T bool is2T
) )
{ {
...@@ -1363,7 +1362,7 @@ static void _PHY_PathADDAOn8723B( ...@@ -1363,7 +1362,7 @@ static void _PHY_PathADDAOn8723B(
ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("ADDA ON.\n")); ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("ADDA ON.\n"));
pathOn = isPathAOn ? 0x01c00014 : 0x01c00014; pathOn = 0x01c00014;
if (false == is2T) { if (false == is2T) {
pathOn = 0x01c00014; pathOn = 0x01c00014;
PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[0], bMaskDWord, 0x01c00014); PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[0], bMaskDWord, 0x01c00014);
...@@ -1556,7 +1555,7 @@ static void phy_IQCalibrate_8723B( ...@@ -1556,7 +1555,7 @@ static void phy_IQCalibrate_8723B(
} }
ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("IQ Calibration for %s for %d times\n", (is2T ? "2T2R" : "1T1R"), t)); ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("IQ Calibration for %s for %d times\n", (is2T ? "2T2R" : "1T1R"), t));
_PHY_PathADDAOn8723B(padapter, ADDA_REG, true, is2T); _PHY_PathADDAOn8723B(padapter, ADDA_REG, is2T);
/* no serial mode */ /* no serial mode */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment