Commit 5fbe9f35 authored by Arvind Yadav's avatar Arvind Yadav Committed by Greg Kroah-Hartman

misc: mic: Release reference count and memory for VOP device

Never directly free @dev after calling device_register(),
even if it returned an error! Always use put_device() to
give up the reference initialized.
Release allocated memory for vop device in vop_release_dev().
Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1b723413
...@@ -135,7 +135,9 @@ EXPORT_SYMBOL_GPL(vop_unregister_driver); ...@@ -135,7 +135,9 @@ EXPORT_SYMBOL_GPL(vop_unregister_driver);
static void vop_release_dev(struct device *d) static void vop_release_dev(struct device *d)
{ {
put_device(d); struct vop_device *dev = dev_to_vop(d);
kfree(dev);
} }
struct vop_device * struct vop_device *
...@@ -174,7 +176,7 @@ vop_register_device(struct device *pdev, int id, ...@@ -174,7 +176,7 @@ vop_register_device(struct device *pdev, int id,
goto free_vdev; goto free_vdev;
return vdev; return vdev;
free_vdev: free_vdev:
kfree(vdev); put_device(&vdev->dev);
return ERR_PTR(ret); return ERR_PTR(ret);
} }
EXPORT_SYMBOL_GPL(vop_register_device); EXPORT_SYMBOL_GPL(vop_register_device);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment