Commit 601555cd authored by Johannes Berg's avatar Johannes Berg

nl80211: don't crash sending invalid chandef

One of the cases for an invalid channel definition is that
the channel pointer is NULL, in which case the warning is
a bit late since we'll dereference the pointer. Bail out
of the function upon warning about this.
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 98f03342
...@@ -2317,7 +2317,8 @@ static inline u64 wdev_id(struct wireless_dev *wdev) ...@@ -2317,7 +2317,8 @@ static inline u64 wdev_id(struct wireless_dev *wdev)
static int nl80211_send_chandef(struct sk_buff *msg, static int nl80211_send_chandef(struct sk_buff *msg,
const struct cfg80211_chan_def *chandef) const struct cfg80211_chan_def *chandef)
{ {
WARN_ON(!cfg80211_chandef_valid(chandef)); if (WARN_ON(!cfg80211_chandef_valid(chandef)))
return -EINVAL;
if (nla_put_u32(msg, NL80211_ATTR_WIPHY_FREQ, if (nla_put_u32(msg, NL80211_ATTR_WIPHY_FREQ,
chandef->chan->center_freq)) chandef->chan->center_freq))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment