Commit 601f887d authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'pm-urgent-4.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

Pull power management fix from Rafael Wysocki:
 "Fix a nasty (and really hard to debug) memory corruption during resume
  from hibernation on x86-64 (that leads to a kernel panic most of the
  time) due to the use of a stale stack pointer value in FRAME_BEGIN
  (Josh Poimboeuf)"

* tag 'pm-urgent-4.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  x86/power/64: Fix hibernation return address corruption
parents 574c7e23 e148d0f8
...@@ -24,7 +24,6 @@ ...@@ -24,7 +24,6 @@
#include <asm/frame.h> #include <asm/frame.h>
ENTRY(swsusp_arch_suspend) ENTRY(swsusp_arch_suspend)
FRAME_BEGIN
movq $saved_context, %rax movq $saved_context, %rax
movq %rsp, pt_regs_sp(%rax) movq %rsp, pt_regs_sp(%rax)
movq %rbp, pt_regs_bp(%rax) movq %rbp, pt_regs_bp(%rax)
...@@ -48,6 +47,7 @@ ENTRY(swsusp_arch_suspend) ...@@ -48,6 +47,7 @@ ENTRY(swsusp_arch_suspend)
movq %cr3, %rax movq %cr3, %rax
movq %rax, restore_cr3(%rip) movq %rax, restore_cr3(%rip)
FRAME_BEGIN
call swsusp_save call swsusp_save
FRAME_END FRAME_END
ret ret
...@@ -104,7 +104,6 @@ ENTRY(core_restore_code) ...@@ -104,7 +104,6 @@ ENTRY(core_restore_code)
/* code below belongs to the image kernel */ /* code below belongs to the image kernel */
.align PAGE_SIZE .align PAGE_SIZE
ENTRY(restore_registers) ENTRY(restore_registers)
FRAME_BEGIN
/* go back to the original page tables */ /* go back to the original page tables */
movq %r9, %cr3 movq %r9, %cr3
...@@ -145,6 +144,5 @@ ENTRY(restore_registers) ...@@ -145,6 +144,5 @@ ENTRY(restore_registers)
/* tell the hibernation core that we've just restored the memory */ /* tell the hibernation core that we've just restored the memory */
movq %rax, in_suspend(%rip) movq %rax, in_suspend(%rip)
FRAME_END
ret ret
ENDPROC(restore_registers) ENDPROC(restore_registers)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment