Commit 60438d9a authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki

tools/power/acpi: close file only if it is open

The logic on the test for a valid fd to close is incorrect.
This was just a mistake and was pointed out by Colin Ian King.

Link: https://patchwork.kernel.org/patch/8620201/Original-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9735a227
...@@ -375,7 +375,7 @@ void usage(FILE *file, char *progname) ...@@ -375,7 +375,7 @@ void usage(FILE *file, char *progname)
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
int fd = 0; int fd = -1;
int ch; int ch;
int len; int len;
int ret = EXIT_SUCCESS; int ret = EXIT_SUCCESS;
...@@ -430,7 +430,7 @@ int main(int argc, char **argv) ...@@ -430,7 +430,7 @@ int main(int argc, char **argv)
acpi_aml_loop(fd); acpi_aml_loop(fd);
exit: exit:
if (fd < 0) if (fd >= 0)
close(fd); close(fd);
if (acpi_aml_batch_cmd) if (acpi_aml_batch_cmd)
free(acpi_aml_batch_cmd); free(acpi_aml_batch_cmd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment