Commit 60648033 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo

perf tools: Use sscanf for parsing /proc/pid/maps

When reading those files to synthesize MMAP events.  It makes the code
shorter and cleaner.
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1352643651-13891-1-git-send-email-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0020ce23
...@@ -193,41 +193,30 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool, ...@@ -193,41 +193,30 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool,
event->header.misc = PERF_RECORD_MISC_USER; event->header.misc = PERF_RECORD_MISC_USER;
while (1) { while (1) {
char bf[BUFSIZ], *pbf = bf; char bf[BUFSIZ];
int n; char prot[5];
char execname[PATH_MAX];
char anonstr[] = "//anon";
size_t size; size_t size;
if (fgets(bf, sizeof(bf), fp) == NULL) if (fgets(bf, sizeof(bf), fp) == NULL)
break; break;
/* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */ /* ensure null termination since stack will be reused. */
n = hex2u64(pbf, &event->mmap.start); strcpy(execname, "");
if (n < 0)
continue;
pbf += n + 1;
n = hex2u64(pbf, &event->mmap.len);
if (n < 0)
continue;
pbf += n + 3;
if (*pbf == 'x') { /* vm_exec */
char anonstr[] = "//anon\n";
char *execname = strchr(bf, '/');
/* Catch VDSO */
if (execname == NULL)
execname = strstr(bf, "[vdso]");
/* Catch anonymous mmaps */ /* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */
if ((execname == NULL) && !strstr(bf, "[")) sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %*x:%*x %*u %s\n",
execname = anonstr; &event->mmap.start, &event->mmap.len, prot,
&event->mmap.pgoff, execname);
if (execname == NULL) if (prot[2] != 'x')
continue; continue;
pbf += 3; if (!strcmp(execname, ""))
n = hex2u64(pbf, &event->mmap.pgoff); strcpy(execname, anonstr);
size = strlen(execname); size = strlen(execname) + 1;
execname[size - 1] = '\0'; /* Remove \n */
memcpy(event->mmap.filename, execname, size); memcpy(event->mmap.filename, execname, size);
size = PERF_ALIGN(size, sizeof(u64)); size = PERF_ALIGN(size, sizeof(u64));
event->mmap.len -= event->mmap.start; event->mmap.len -= event->mmap.start;
...@@ -243,7 +232,6 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool, ...@@ -243,7 +232,6 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool,
break; break;
} }
} }
}
fclose(fp); fclose(fp);
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment