Commit 609dd342 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: remove this_board macro in the serial2002 driver

The 'thisboard' macro depends on having a local variable with
a magic name. The CodingStyle document suggests not doing this
to avoid confusion. Remove the macro and use the comedi_board()
inline helper to get the dev->board_ptr information.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ad401db6
...@@ -47,11 +47,6 @@ struct serial2002_board { ...@@ -47,11 +47,6 @@ struct serial2002_board {
const char *name; const char *name;
}; };
/*
* Useful for shorthand access to the particular board structure
*/
#define thisboard ((const struct serial2002_board *)dev->board_ptr)
struct serial2002_range_table_t { struct serial2002_range_table_t {
/* HACK... */ /* HACK... */
...@@ -783,10 +778,11 @@ static int serial2002_ei_rinsn(struct comedi_device *dev, ...@@ -783,10 +778,11 @@ static int serial2002_ei_rinsn(struct comedi_device *dev,
static int serial2002_attach(struct comedi_device *dev, static int serial2002_attach(struct comedi_device *dev,
struct comedi_devconfig *it) struct comedi_devconfig *it)
{ {
const struct serial2002_board *board = comedi_board(dev);
struct comedi_subdevice *s; struct comedi_subdevice *s;
dev_dbg(dev->hw_dev, "comedi%d: attached\n", dev->minor); dev_dbg(dev->hw_dev, "comedi%d: attached\n", dev->minor);
dev->board_name = thisboard->name; dev->board_name = board->name;
if (alloc_private(dev, sizeof(struct serial2002_private)) < 0) if (alloc_private(dev, sizeof(struct serial2002_private)) < 0)
return -ENOMEM; return -ENOMEM;
dev->open = serial_2002_open; dev->open = serial_2002_open;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment