Commit 669b710e authored by Philippe CORNU's avatar Philippe CORNU Committed by Andrzej Hajda

drm/bridge/synopsys: dsi: readl_poll_timeout return value clean up

The readl_poll_timeout() return value is 0 in case of success
so it is better to detect errors without taking care of the
return value sign.
Signed-off-by: default avatarPhilippe Cornu <philippe.cornu@st.com>
Reviewed-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180204213624.18288-1-philippe.cornu@st.com
parent 5fcdc9d9
...@@ -342,7 +342,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) ...@@ -342,7 +342,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val)
ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS,
val, !(val & GEN_CMD_FULL), 1000, val, !(val & GEN_CMD_FULL), 1000,
CMD_PKT_STATUS_TIMEOUT_US); CMD_PKT_STATUS_TIMEOUT_US);
if (ret < 0) { if (ret) {
dev_err(dsi->dev, "failed to get available command FIFO\n"); dev_err(dsi->dev, "failed to get available command FIFO\n");
return ret; return ret;
} }
...@@ -353,7 +353,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) ...@@ -353,7 +353,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val)
ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS,
val, (val & mask) == mask, val, (val & mask) == mask,
1000, CMD_PKT_STATUS_TIMEOUT_US); 1000, CMD_PKT_STATUS_TIMEOUT_US);
if (ret < 0) { if (ret) {
dev_err(dsi->dev, "failed to write command FIFO\n"); dev_err(dsi->dev, "failed to write command FIFO\n");
return ret; return ret;
} }
...@@ -385,7 +385,7 @@ static int dw_mipi_dsi_write(struct dw_mipi_dsi *dsi, ...@@ -385,7 +385,7 @@ static int dw_mipi_dsi_write(struct dw_mipi_dsi *dsi,
ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS,
val, !(val & GEN_PLD_W_FULL), 1000, val, !(val & GEN_PLD_W_FULL), 1000,
CMD_PKT_STATUS_TIMEOUT_US); CMD_PKT_STATUS_TIMEOUT_US);
if (ret < 0) { if (ret) {
dev_err(dsi->dev, dev_err(dsi->dev,
"failed to get available write payload FIFO\n"); "failed to get available write payload FIFO\n");
return ret; return ret;
...@@ -721,13 +721,13 @@ static void dw_mipi_dsi_dphy_enable(struct dw_mipi_dsi *dsi) ...@@ -721,13 +721,13 @@ static void dw_mipi_dsi_dphy_enable(struct dw_mipi_dsi *dsi)
ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, val, ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, val,
val & PHY_LOCK, 1000, PHY_STATUS_TIMEOUT_US); val & PHY_LOCK, 1000, PHY_STATUS_TIMEOUT_US);
if (ret < 0) if (ret)
DRM_DEBUG_DRIVER("failed to wait phy lock state\n"); DRM_DEBUG_DRIVER("failed to wait phy lock state\n");
ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS,
val, val & PHY_STOP_STATE_CLK_LANE, 1000, val, val & PHY_STOP_STATE_CLK_LANE, 1000,
PHY_STATUS_TIMEOUT_US); PHY_STATUS_TIMEOUT_US);
if (ret < 0) if (ret)
DRM_DEBUG_DRIVER("failed to wait phy clk lane stop state\n"); DRM_DEBUG_DRIVER("failed to wait phy clk lane stop state\n");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment