Commit 68d35c7b authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman

parport: fix freeing freed memory

After the reference count becomes 0 when put_device() is called, it will
execute the release callback where we are freeing all the allocated
memory associated with the device. So if we just continue on the error
path then we are again freeing devname and trying to dereference par_dev
which has already been free-ed in the release callback.
Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 23c40591
...@@ -892,8 +892,10 @@ parport_register_dev_model(struct parport *port, const char *name, ...@@ -892,8 +892,10 @@ parport_register_dev_model(struct parport *port, const char *name,
par_dev->dev.release = free_pardevice; par_dev->dev.release = free_pardevice;
par_dev->devmodel = true; par_dev->devmodel = true;
ret = device_register(&par_dev->dev); ret = device_register(&par_dev->dev);
if (ret) if (ret) {
goto err_put_dev; put_device(&par_dev->dev);
goto err_put_port;
}
/* Chain this onto the list */ /* Chain this onto the list */
par_dev->prev = NULL; par_dev->prev = NULL;
...@@ -940,8 +942,6 @@ parport_register_dev_model(struct parport *port, const char *name, ...@@ -940,8 +942,6 @@ parport_register_dev_model(struct parport *port, const char *name,
return par_dev; return par_dev;
err_put_dev:
put_device(&par_dev->dev);
err_free_devname: err_free_devname:
kfree(devname); kfree(devname);
err_free_par_dev: err_free_par_dev:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment