Commit 6c53cbfc authored by Borislav Petkov's avatar Borislav Petkov

x86, microcode: Correct sysdev_add error path

When we encounter an error while initting the microcode driver on a CPU,
we must undo the previously added sysfs group.

Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Signed-off-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
Acked-by: default avatarAndreas Herrmann <Andreas.Herrmann3@amd.com>
parent 100b33c8
...@@ -417,8 +417,10 @@ static int mc_sysdev_add(struct sys_device *sys_dev) ...@@ -417,8 +417,10 @@ static int mc_sysdev_add(struct sys_device *sys_dev)
if (err) if (err)
return err; return err;
if (microcode_init_cpu(cpu) == UCODE_ERROR) if (microcode_init_cpu(cpu) == UCODE_ERROR) {
err = -EINVAL; sysfs_remove_group(&sys_dev->kobj, &mc_attr_group);
return -EINVAL;
}
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment