Commit 6d4472d7 authored by Hillf Danton's avatar Hillf Danton Committed by Jiri Kosina

HID: hiddev: do cleanup in failure of opening a device

Undo what we did for opening before releasing the memory slice.
Reported-by: default avatarsyzbot <syzbot+62a1e04fd3ec2abf099e@syzkaller.appspotmail.com>
Cc: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: default avatarHillf Danton <hdanton@sina.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 9c09b214
...@@ -308,6 +308,10 @@ static int hiddev_open(struct inode *inode, struct file *file) ...@@ -308,6 +308,10 @@ static int hiddev_open(struct inode *inode, struct file *file)
hid_hw_power(hid, PM_HINT_NORMAL); hid_hw_power(hid, PM_HINT_NORMAL);
bail_unlock: bail_unlock:
mutex_unlock(&hiddev->existancelock); mutex_unlock(&hiddev->existancelock);
spin_lock_irq(&list->hiddev->list_lock);
list_del(&list->node);
spin_unlock_irq(&list->hiddev->list_lock);
bail: bail:
file->private_data = NULL; file->private_data = NULL;
vfree(list); vfree(list);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment