Commit 6e14adea authored by Aurabindo Pillai's avatar Aurabindo Pillai Committed by Alex Deucher

drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

The buffer allocated is of 1024 bytes. Allocate this from
heap instead of stack.

Also remove check for stack size since we're allocating from heap
Signed-off-by: default avatarAurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: default avatarAmber Lin <Amber.Lin@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 91e2c191
...@@ -78,9 +78,11 @@ static ssize_t kfd_smi_ev_read(struct file *filep, char __user *user, ...@@ -78,9 +78,11 @@ static ssize_t kfd_smi_ev_read(struct file *filep, char __user *user,
int ret; int ret;
size_t to_copy; size_t to_copy;
struct kfd_smi_client *client = filep->private_data; struct kfd_smi_client *client = filep->private_data;
unsigned char buf[MAX_KFIFO_SIZE]; unsigned char *buf;
BUILD_BUG_ON(MAX_KFIFO_SIZE > 1024); buf = kmalloc(MAX_KFIFO_SIZE * sizeof(*buf), GFP_KERNEL);
if (!buf)
return -ENOMEM;
/* kfifo_to_user can sleep so we can't use spinlock protection around /* kfifo_to_user can sleep so we can't use spinlock protection around
* it. Instead, we kfifo out as spinlocked then copy them to the user. * it. Instead, we kfifo out as spinlocked then copy them to the user.
...@@ -89,19 +91,29 @@ static ssize_t kfd_smi_ev_read(struct file *filep, char __user *user, ...@@ -89,19 +91,29 @@ static ssize_t kfd_smi_ev_read(struct file *filep, char __user *user,
to_copy = kfifo_len(&client->fifo); to_copy = kfifo_len(&client->fifo);
if (!to_copy) { if (!to_copy) {
spin_unlock(&client->lock); spin_unlock(&client->lock);
return -EAGAIN; ret = -EAGAIN;
goto ret_err;
} }
to_copy = min3(size, sizeof(buf), to_copy); to_copy = min3(size, sizeof(buf), to_copy);
ret = kfifo_out(&client->fifo, buf, to_copy); ret = kfifo_out(&client->fifo, buf, to_copy);
spin_unlock(&client->lock); spin_unlock(&client->lock);
if (ret <= 0) if (ret <= 0) {
return -EAGAIN; ret = -EAGAIN;
goto ret_err;
}
ret = copy_to_user(user, buf, to_copy); ret = copy_to_user(user, buf, to_copy);
if (ret) if (ret) {
return -EFAULT; ret = -EFAULT;
goto ret_err;
}
kfree(buf);
return to_copy; return to_copy;
ret_err:
kfree(buf);
return ret;
} }
static ssize_t kfd_smi_ev_write(struct file *filep, const char __user *user, static ssize_t kfd_smi_ev_write(struct file *filep, const char __user *user,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment