Commit 7352e252 authored by Sean Wang's avatar Sean Wang Committed by David S. Miller

net: mediatek: setup proper state for disabled GMAC on the default

The current solution would setup fixed and force link of 1Gbps to the both
GMAC on the default. However, The GMAC should always be put to link down
state when the GMAC is disabled on certain target boards. Otherwise,
the driver possibly receives unexpected data from the floating hardware
connection through the unused GMAC. Although the driver had been added
certain protection in RX path to get rid of such kind of unexpected data
sent to the upper stack.
Signed-off-by: default avatarSean Wang <sean.wang@mediatek.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8ba6b30e
...@@ -1961,11 +1961,12 @@ static int mtk_hw_init(struct mtk_eth *eth) ...@@ -1961,11 +1961,12 @@ static int mtk_hw_init(struct mtk_eth *eth)
/* set GE2 TUNE */ /* set GE2 TUNE */
regmap_write(eth->pctl, GPIO_BIAS_CTRL, 0x0); regmap_write(eth->pctl, GPIO_BIAS_CTRL, 0x0);
/* GE1, Force 1000M/FD, FC ON */ /* Set linkdown as the default for each GMAC. Its own MCR would be set
mtk_w32(eth, MAC_MCR_FIXED_LINK, MTK_MAC_MCR(0)); * up with the more appropriate value when mtk_phy_link_adjust call is
* being invoked.
/* GE2, Force 1000M/FD, FC ON */ */
mtk_w32(eth, MAC_MCR_FIXED_LINK, MTK_MAC_MCR(1)); for (i = 0; i < MTK_MAC_COUNT; i++)
mtk_w32(eth, 0, MTK_MAC_MCR(i));
/* Indicates CDM to parse the MTK special tag from CPU /* Indicates CDM to parse the MTK special tag from CPU
* which also is working out for untag packets. * which also is working out for untag packets.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment