Commit 7364e445 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by David S. Miller

net/core: Fix potential memory leak in dev_set_alias()

Do not leak memory by updating pointer with potentially NULL realloc return value.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47dffc75
...@@ -1055,6 +1055,8 @@ int dev_change_name(struct net_device *dev, const char *newname) ...@@ -1055,6 +1055,8 @@ int dev_change_name(struct net_device *dev, const char *newname)
*/ */
int dev_set_alias(struct net_device *dev, const char *alias, size_t len) int dev_set_alias(struct net_device *dev, const char *alias, size_t len)
{ {
char *new_ifalias;
ASSERT_RTNL(); ASSERT_RTNL();
if (len >= IFALIASZ) if (len >= IFALIASZ)
...@@ -1068,9 +1070,10 @@ int dev_set_alias(struct net_device *dev, const char *alias, size_t len) ...@@ -1068,9 +1070,10 @@ int dev_set_alias(struct net_device *dev, const char *alias, size_t len)
return 0; return 0;
} }
dev->ifalias = krealloc(dev->ifalias, len + 1, GFP_KERNEL); new_ifalias = krealloc(dev->ifalias, len + 1, GFP_KERNEL);
if (!dev->ifalias) if (!new_ifalias)
return -ENOMEM; return -ENOMEM;
dev->ifalias = new_ifalias;
strlcpy(dev->ifalias, alias, len+1); strlcpy(dev->ifalias, alias, len+1);
return len; return len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment