Commit 73cb3106 authored by Colin Ian King's avatar Colin Ian King Committed by Stephen Boyd

clk: ls1028a: fix a dereference of pointer 'parent' before a null check

Currently the pointer 'parent' is being dereferenced before it is
being null checked. Fix this by performing the null check before
it is dereferenced.

Addresses-Coverity: ("Dereference before null check")
Fixes: d37010a3 ("clk: ls1028a: Add clock driver for Display output interface")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lkml.kernel.org/r/20200203223736.99645-1-colin.king@canonical.comSigned-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 2a8aa18c
...@@ -187,7 +187,7 @@ static int plldig_init(struct clk_hw *hw) ...@@ -187,7 +187,7 @@ static int plldig_init(struct clk_hw *hw)
{ {
struct clk_plldig *data = to_clk_plldig(hw); struct clk_plldig *data = to_clk_plldig(hw);
struct clk_hw *parent = clk_hw_get_parent(hw); struct clk_hw *parent = clk_hw_get_parent(hw);
unsigned long parent_rate = clk_hw_get_rate(parent); unsigned long parent_rate;
unsigned long val; unsigned long val;
unsigned long long lltmp; unsigned long long lltmp;
unsigned int mfd, fracdiv = 0; unsigned int mfd, fracdiv = 0;
...@@ -195,6 +195,8 @@ static int plldig_init(struct clk_hw *hw) ...@@ -195,6 +195,8 @@ static int plldig_init(struct clk_hw *hw)
if (!parent) if (!parent)
return -EINVAL; return -EINVAL;
parent_rate = clk_hw_get_rate(parent);
if (data->vco_freq) { if (data->vco_freq) {
mfd = data->vco_freq / parent_rate; mfd = data->vco_freq / parent_rate;
lltmp = data->vco_freq % parent_rate; lltmp = data->vco_freq % parent_rate;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment