Commit 75cfe338 authored by Luca Coelho's avatar Luca Coelho

iwlwifi: mvm: bail out if CTDP start operation fails

We were assigning the return value of iwl_mvm_ctdp_command() to a
variable, but never checking it.  If this command fails, we should not
allow the interface up process to proceed, since it is potentially
dangerous to ignore thermal management requirements.

Fixes: commit 5c89e7bc ("iwlwifi: mvm: add registration to cooling device")
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent cc2f41f8
...@@ -1233,9 +1233,12 @@ int iwl_mvm_up(struct iwl_mvm *mvm) ...@@ -1233,9 +1233,12 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
} }
/* TODO: read the budget from BIOS / Platform NVM */ /* TODO: read the budget from BIOS / Platform NVM */
if (iwl_mvm_is_ctdp_supported(mvm) && mvm->cooling_dev.cur_state > 0) if (iwl_mvm_is_ctdp_supported(mvm) && mvm->cooling_dev.cur_state > 0) {
ret = iwl_mvm_ctdp_command(mvm, CTDP_CMD_OPERATION_START, ret = iwl_mvm_ctdp_command(mvm, CTDP_CMD_OPERATION_START,
mvm->cooling_dev.cur_state); mvm->cooling_dev.cur_state);
if (ret)
goto error;
}
#else #else
/* Initialize tx backoffs to the minimal possible */ /* Initialize tx backoffs to the minimal possible */
iwl_mvm_tt_tx_backoff(mvm, 0); iwl_mvm_tt_tx_backoff(mvm, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment