Commit 76cc173d authored by Nikolay Aleksandrov's avatar Nikolay Aleksandrov Committed by David S. Miller

bridge: mdb: reduce the indentation level in br_mdb_fill_info

Switch the port check and skip if it's null, this allows us to reduce one
indentation level.
Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6bbd9a05
...@@ -88,9 +88,11 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -88,9 +88,11 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
for (pp = &mp->ports; for (pp = &mp->ports;
(p = rcu_dereference(*pp)) != NULL; (p = rcu_dereference(*pp)) != NULL;
pp = &p->next) { pp = &p->next) {
port = p->port;
if (port) {
struct br_mdb_entry e; struct br_mdb_entry e;
port = p->port;
if (!port)
continue;
memset(&e, 0, sizeof(e)); memset(&e, 0, sizeof(e));
e.ifindex = port->dev->ifindex; e.ifindex = port->dev->ifindex;
e.vid = p->addr.vid; e.vid = p->addr.vid;
...@@ -108,7 +110,6 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -108,7 +110,6 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
goto out; goto out;
} }
} }
}
nla_nest_end(skb, nest2); nla_nest_end(skb, nest2);
skip: skip:
idx++; idx++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment