Commit 776b0aa9 authored by Colin Ian King's avatar Colin Ian King Committed by Bartlomiej Zolnierkiewicz

fbdev: matrox: make array wtst_xlat static const, makes object smaller

Don't populate the array wtst_xlat on the stack but instead make it
static const. Makes the object code smaller by 89 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  14347	    840	      0	  15187	   3b53	fbdev/matrox/matroxfb_misc.o

After:
   text	   data	    bss	    dec	    hex	filename
  14162	    936	      0	  15098	   3afa	fbdev/matrox/matroxfb_misc.o

(gcc version 9.2.1, amd64)
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
[b.zolnierkie: use u8 while at it (suggested by Ville Syrjälä)]
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190906181114.31414-1-colin.king@canonical.com
parent 3149299e
...@@ -673,7 +673,10 @@ static int parse_pins5(struct matrox_fb_info *minfo, ...@@ -673,7 +673,10 @@ static int parse_pins5(struct matrox_fb_info *minfo,
if (bd->pins[115] & 4) { if (bd->pins[115] & 4) {
minfo->values.reg.mctlwtst_core = minfo->values.reg.mctlwtst; minfo->values.reg.mctlwtst_core = minfo->values.reg.mctlwtst;
} else { } else {
u_int32_t wtst_xlat[] = { 0, 1, 5, 6, 7, 5, 2, 3 }; static const u8 wtst_xlat[] = {
0, 1, 5, 6, 7, 5, 2, 3
};
minfo->values.reg.mctlwtst_core = (minfo->values.reg.mctlwtst & ~7) | minfo->values.reg.mctlwtst_core = (minfo->values.reg.mctlwtst & ~7) |
wtst_xlat[minfo->values.reg.mctlwtst & 7]; wtst_xlat[minfo->values.reg.mctlwtst & 7];
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment