Commit 78866efe authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab

[media] v4l2-controls.txt: update to latest v4l2-ctrl.c changes

Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ddac5c10
...@@ -277,16 +277,13 @@ implement g_volatile_ctrl like this: ...@@ -277,16 +277,13 @@ implement g_volatile_ctrl like this:
{ {
switch (ctrl->id) { switch (ctrl->id) {
case V4L2_CID_BRIGHTNESS: case V4L2_CID_BRIGHTNESS:
ctrl->cur.val = read_reg(0x123); ctrl->val = read_reg(0x123);
break; break;
} }
} }
The 'new value' union is not used in g_volatile_ctrl. In general controls Note that you use the 'new value' union as well in g_volatile_ctrl. In general
that need to implement g_volatile_ctrl are read-only controls. controls that need to implement g_volatile_ctrl are read-only controls.
Note that if one or more controls in a control cluster are marked as volatile,
then all the controls in the cluster are seen as volatile.
To mark a control as volatile you have to set the is_volatile flag: To mark a control as volatile you have to set the is_volatile flag:
...@@ -636,9 +633,7 @@ button controls are write-only controls. ...@@ -636,9 +633,7 @@ button controls are write-only controls.
-EINVAL as the spec says. -EINVAL as the spec says.
5) The spec does not mention what should happen when you try to set/get a 5) The spec does not mention what should happen when you try to set/get a
control class controls. ivtv currently returns -EINVAL (indicating that the control class controls. The framework will return -EACCES.
control ID does not exist) while the framework will return -EACCES, which
makes more sense.
Proposals for Extensions Proposals for Extensions
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment