Commit 7df4a691 authored by Mark Hills's avatar Mark Hills Committed by Takashi Iwai

ALSA: usb-audio: Fix comment

Explained by Takashi in <s5hfwbtmz0q.wl%tiwai@suse.de>

> The reason is because get_min_max*() isn't called in the place you
> created these controls, and get_min_max() would be called only for
> integer volumes later even if uninitialized.  A short cut for booleans.
Signed-off-by: default avatarMark Hills <mark@pogo.org.uk>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0910c216
...@@ -79,16 +79,8 @@ static int snd_create_std_mono_ctl(struct usb_mixer_interface *mixer, ...@@ -79,16 +79,8 @@ static int snd_create_std_mono_ctl(struct usb_mixer_interface *mixer,
cval->control = control; cval->control = control;
cval->cmask = cmask; cval->cmask = cmask;
/* FIXME: Do we need this? /* get_min_max() is called only for integer volumes later,
* The following values are for compatibility with * so provide a short-cut for booleans */
* Ebox-44 mixer.
* But the corresponding ebox-44 function says:
* "Volume controls will override these values"
*
* These values don't have any effect at all for
* M-Audio FTUs.
* So I think, we can safely omit the range settings here.
*/
cval->min = 0; cval->min = 0;
cval->max = 1; cval->max = 1;
cval->res = 0; cval->res = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment