Commit 7f2ea957 authored by Ondrej Zary's avatar Ondrej Zary Committed by Tomi Valkeinen

tridentfb: fix hang on Blade3D with CONFIG_CC_OPTIMIZE_FOR_SIZE

When the kernel is compiled with -Os (CONFIG_CC_OPTIMIZE_FOR_SIZE), tridentfb
hangs the machine upon load with Blade3D cards unless acceleration is disabled.

This is caused by memcpy() which copies data byte-by-byte (rep movsb) when
compiled with -Os. The card does not like that - it requires 32-bit access.

Use iowrite_32() instead.
Signed-off-by: default avatarOndrej Zary <linux@rainbow-software.org>
Acked-by: default avatarKrzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 8e9191ac
...@@ -226,7 +226,7 @@ static void blade_image_blit(struct tridentfb_par *par, const char *data, ...@@ -226,7 +226,7 @@ static void blade_image_blit(struct tridentfb_par *par, const char *data,
writemmr(par, DST1, point(x, y)); writemmr(par, DST1, point(x, y));
writemmr(par, DST2, point(x + w - 1, y + h - 1)); writemmr(par, DST2, point(x + w - 1, y + h - 1));
memcpy(par->io_virt + 0x10000, data, 4 * size); iowrite32_rep(par->io_virt + 0x10000, data, size);
} }
static void blade_copy_rect(struct tridentfb_par *par, static void blade_copy_rect(struct tridentfb_par *par,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment