Commit 827a9b8b authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Linus Walleij

gpiolib: Clarify use of non-sleeping functions

Obviously functions that are safe to be called from atomic contexts, can
be called from non-atomic contexts, too.
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190701142809.25308-1-geert+renesas@glider.beSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 3285170f
...@@ -3031,7 +3031,7 @@ int gpiod_get_array_value_complex(bool raw, bool can_sleep, ...@@ -3031,7 +3031,7 @@ int gpiod_get_array_value_complex(bool raw, bool can_sleep,
* Return the GPIO's raw value, i.e. the value of the physical line disregarding * Return the GPIO's raw value, i.e. the value of the physical line disregarding
* its ACTIVE_LOW status, or negative errno on failure. * its ACTIVE_LOW status, or negative errno on failure.
* *
* This function should be called from contexts where we cannot sleep, and will * This function can be called from contexts where we cannot sleep, and will
* complain if the GPIO chip functions potentially sleep. * complain if the GPIO chip functions potentially sleep.
*/ */
int gpiod_get_raw_value(const struct gpio_desc *desc) int gpiod_get_raw_value(const struct gpio_desc *desc)
...@@ -3050,7 +3050,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_raw_value); ...@@ -3050,7 +3050,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_raw_value);
* Return the GPIO's logical value, i.e. taking the ACTIVE_LOW status into * Return the GPIO's logical value, i.e. taking the ACTIVE_LOW status into
* account, or negative errno on failure. * account, or negative errno on failure.
* *
* This function should be called from contexts where we cannot sleep, and will * This function can be called from contexts where we cannot sleep, and will
* complain if the GPIO chip functions potentially sleep. * complain if the GPIO chip functions potentially sleep.
*/ */
int gpiod_get_value(const struct gpio_desc *desc) int gpiod_get_value(const struct gpio_desc *desc)
...@@ -3083,7 +3083,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_value); ...@@ -3083,7 +3083,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_value);
* without regard for their ACTIVE_LOW status. Return 0 in case of success, * without regard for their ACTIVE_LOW status. Return 0 in case of success,
* else an error code. * else an error code.
* *
* This function should be called from contexts where we cannot sleep, * This function can be called from contexts where we cannot sleep,
* and it will complain if the GPIO chip functions potentially sleep. * and it will complain if the GPIO chip functions potentially sleep.
*/ */
int gpiod_get_raw_array_value(unsigned int array_size, int gpiod_get_raw_array_value(unsigned int array_size,
...@@ -3109,7 +3109,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_raw_array_value); ...@@ -3109,7 +3109,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_raw_array_value);
* Read the logical values of the GPIOs, i.e. taking their ACTIVE_LOW status * Read the logical values of the GPIOs, i.e. taking their ACTIVE_LOW status
* into account. Return 0 in case of success, else an error code. * into account. Return 0 in case of success, else an error code.
* *
* This function should be called from contexts where we cannot sleep, * This function can be called from contexts where we cannot sleep,
* and it will complain if the GPIO chip functions potentially sleep. * and it will complain if the GPIO chip functions potentially sleep.
*/ */
int gpiod_get_array_value(unsigned int array_size, int gpiod_get_array_value(unsigned int array_size,
...@@ -3323,7 +3323,7 @@ int gpiod_set_array_value_complex(bool raw, bool can_sleep, ...@@ -3323,7 +3323,7 @@ int gpiod_set_array_value_complex(bool raw, bool can_sleep,
* Set the raw value of the GPIO, i.e. the value of its physical line without * Set the raw value of the GPIO, i.e. the value of its physical line without
* regard for its ACTIVE_LOW status. * regard for its ACTIVE_LOW status.
* *
* This function should be called from contexts where we cannot sleep, and will * This function can be called from contexts where we cannot sleep, and will
* complain if the GPIO chip functions potentially sleep. * complain if the GPIO chip functions potentially sleep.
*/ */
void gpiod_set_raw_value(struct gpio_desc *desc, int value) void gpiod_set_raw_value(struct gpio_desc *desc, int value)
...@@ -3364,7 +3364,7 @@ static void gpiod_set_value_nocheck(struct gpio_desc *desc, int value) ...@@ -3364,7 +3364,7 @@ static void gpiod_set_value_nocheck(struct gpio_desc *desc, int value)
* Set the logical value of the GPIO, i.e. taking its ACTIVE_LOW, * Set the logical value of the GPIO, i.e. taking its ACTIVE_LOW,
* OPEN_DRAIN and OPEN_SOURCE flags into account. * OPEN_DRAIN and OPEN_SOURCE flags into account.
* *
* This function should be called from contexts where we cannot sleep, and will * This function can be called from contexts where we cannot sleep, and will
* complain if the GPIO chip functions potentially sleep. * complain if the GPIO chip functions potentially sleep.
*/ */
void gpiod_set_value(struct gpio_desc *desc, int value) void gpiod_set_value(struct gpio_desc *desc, int value)
...@@ -3386,7 +3386,7 @@ EXPORT_SYMBOL_GPL(gpiod_set_value); ...@@ -3386,7 +3386,7 @@ EXPORT_SYMBOL_GPL(gpiod_set_value);
* Set the raw values of the GPIOs, i.e. the values of the physical lines * Set the raw values of the GPIOs, i.e. the values of the physical lines
* without regard for their ACTIVE_LOW status. * without regard for their ACTIVE_LOW status.
* *
* This function should be called from contexts where we cannot sleep, and will * This function can be called from contexts where we cannot sleep, and will
* complain if the GPIO chip functions potentially sleep. * complain if the GPIO chip functions potentially sleep.
*/ */
int gpiod_set_raw_array_value(unsigned int array_size, int gpiod_set_raw_array_value(unsigned int array_size,
...@@ -3411,7 +3411,7 @@ EXPORT_SYMBOL_GPL(gpiod_set_raw_array_value); ...@@ -3411,7 +3411,7 @@ EXPORT_SYMBOL_GPL(gpiod_set_raw_array_value);
* Set the logical values of the GPIOs, i.e. taking their ACTIVE_LOW status * Set the logical values of the GPIOs, i.e. taking their ACTIVE_LOW status
* into account. * into account.
* *
* This function should be called from contexts where we cannot sleep, and will * This function can be called from contexts where we cannot sleep, and will
* complain if the GPIO chip functions potentially sleep. * complain if the GPIO chip functions potentially sleep.
*/ */
int gpiod_set_array_value(unsigned int array_size, int gpiod_set_array_value(unsigned int array_size,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment