Commit 8453580c authored by Hanno Böck's avatar Hanno Böck Committed by Daniel Vetter

drm/i915: Fix command parser table validator

As we may like to use a bisection search on the tables in future, we
need them to be ordered. For convenience we expect the compiled tables
to be order and check on initialisation. However, the validator used the
wrong iterators failed to spot the misordered MI tables and instead
walked off into the unknown (as spotted by kasan).
Signed-off-by: default avatarHanno Boeck <hanno@hboeck.de>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
[danvet: Again hand-assemble patch ...]
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
parent 9f58582c
...@@ -564,7 +564,7 @@ static bool validate_cmds_sorted(struct intel_engine_cs *ring, ...@@ -564,7 +564,7 @@ static bool validate_cmds_sorted(struct intel_engine_cs *ring,
for (j = 0; j < table->count; j++) { for (j = 0; j < table->count; j++) {
const struct drm_i915_cmd_descriptor *desc = const struct drm_i915_cmd_descriptor *desc =
&table->table[i]; &table->table[j];
u32 curr = desc->cmd.value & desc->cmd.mask; u32 curr = desc->cmd.value & desc->cmd.mask;
if (curr < previous) { if (curr < previous) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment