Commit 85cc0288 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Ralf Baechle

mips: make loongsoon serial driver explicitly modular

The file looks as if it is non-modular, but it piggy-backs
off CONFIG_SERIAL_8250 which is tristate.  If set to "=m"
we will get this after the init/module header cleanup:

arch/mips/loongson/common/serial.c:76:1: error: data definition has no type or storage class [-Werror]
arch/mips/loongson/common/serial.c:76:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int]
arch/mips/loongson/common/serial.c:76:1: error: parameter names (without types) in function declaration [-Werror]
arch/mips/loongson/common/serial.c:58:19: error: 'serial_init' defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
make[3]: *** [arch/mips/loongson/common/serial.o] Error 1

Make it clearly modular, and add a module_exit function,
so that we avoid the above breakage.
Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 52ea7bff
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
*/ */
#include <linux/io.h> #include <linux/io.h>
#include <linux/init.h> #include <linux/module.h>
#include <linux/serial_8250.h> #include <linux/serial_8250.h>
#include <asm/bootinfo.h> #include <asm/bootinfo.h>
...@@ -108,5 +108,10 @@ static int __init serial_init(void) ...@@ -108,5 +108,10 @@ static int __init serial_init(void)
return platform_device_register(&uart8250_device); return platform_device_register(&uart8250_device);
} }
module_init(serial_init);
device_initcall(serial_init); static void __init serial_exit(void)
{
platform_device_unregister(&uart8250_device);
}
module_exit(serial_exit);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment